Fix python3 jupyter problem with EnvironmentBlock null char

Author: vors

powershell_kernel/install.py

@@ -40,6 +40,7 @@ def install_my_kernel_spec(user=True, prefix=None, powershell_command=None):
     else:
         # python 2 cannot use env to pass values to the kernel
         # https://github.com/vors/jupyter-powershell/issues/7
+        # TODO(python2): find a way to pass it
         if powershell_command is not None:
             print('Ignoring powershell_command on python2, jupyter will use default powershell_command=%r' % powershell_command)
 

powershell_kernel/kernel.py

@@ -41,7 +41,7 @@ def __init__(self, **kwargs):
 
         # powershell_command env variable is set by the kernel to allow both powershell and pwsh
         # but on python2 we cannot pass it thru env variable, see https://github.com/vors/jupyter-powershell/issues/7
-        # TODO: can we pass it somehow differently and still provide user-picked value on python2?
+        # TODO(python2): can we pass it somehow differently and still provide user-picked value on python2?
         try:
             powershell_command = environ['powershell_command']
         except:

powershell_kernel/killableprocess/winprocess.py

@@ -37,6 +37,7 @@
 from ctypes import c_void_p, POINTER, sizeof, Structure, windll, WinError, WINFUNCTYPE
 from ctypes.wintypes import BOOL, BYTE, DWORD, HANDLE, LPCWSTR, LPWSTR, UINT, WORD
 from .qijo import QueryInformationJobObject
+from sys import version_info
 
 LPVOID = c_void_p
 LPBYTE = POINTER(BYTE)
@@ -138,10 +139,15 @@ def __init__(self, dict):
         if not dict:
             self._as_parameter_ = None
         else:
-            values = ["%s=%s" % (key, value)
-                      for (key, value) in dict.items()]
-            values.append("")
-            self._as_parameter_ = LPCWSTR("\0".join(values))
+            if version_info >= (3, 0):
+              # on python3 LPCWSTR("\0") errors with 'ValueError: embedded null character'
+              # TODO(python3): find a proper fix for that
+              self._as_parameter_ = None
+            else:
+              values = ["%s=%s" % (key, value)
+                        for (key, value) in dict.items()]
+              values.append("")
+              self._as_parameter_ = LPCWSTR("\0".join(values))
 
 # CreateProcess()