Skip to content

Commit 6a9fffa

Browse files
committed
third party: fixed builds with non-alphanumeric characters in module names
Closes nginx#540 Fixes nginx#550
1 parent fe33fad commit 6a9fffa

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

modules/Dockerfile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,25 +42,28 @@ RUN set -ex \
4242
/modules/$module/prebuild; \
4343
fi; \
4444
/pkg-oss/build_module.sh -v $NGINX_VERSION -f -y -o /tmp/packages -n $module $(cat /modules/$module/source); \
45+
BUILT_MODULES="$BUILT_MODULES $(echo $module | tr '[A-Z]' '[a-z]' | tr -d '[/_\-\.\t ]')"; \
4546
elif make -C /pkg-oss/debian list | grep -P "^$module\s+\d" > /dev/null; then \
4647
echo "Building $module from pkg-oss sources"; \
4748
cd /pkg-oss/debian; \
4849
make rules-module-$module BASE_VERSION=$NGINX_VERSION NGINX_VERSION=$NGINX_VERSION; \
4950
mk-build-deps --install --tool="apt-get -o Debug::pkgProblemResolver=yes --no-install-recommends --yes" debuild-module-$module/nginx-$NGINX_VERSION/debian/control; \
5051
make module-$module BASE_VERSION=$NGINX_VERSION NGINX_VERSION=$NGINX_VERSION; \
5152
find ../../ -maxdepth 1 -mindepth 1 -type f -name "*.deb" -exec mv -v {} /tmp/packages/ \;; \
53+
BUILT_MODULES="$BUILT_MODULES $module"; \
5254
else \
5355
echo "Don't know how to build $module module, exiting"; \
5456
exit 1; \
5557
fi; \
56-
done
58+
done \
59+
&& echo "BUILT_MODULES=\"$BUILT_MODULES\"" > /tmp/packages/modules.env
5760

5861
FROM nginx:mainline
59-
ARG ENABLED_MODULES
6062
COPY --from=builder /tmp/packages /tmp/packages
6163
RUN set -ex \
6264
&& apt update \
63-
&& for module in $ENABLED_MODULES; do \
65+
&& . /tmp/packages/modules.env \
66+
&& for module in $BUILT_MODULES; do \
6467
apt install --no-install-suggests --no-install-recommends -y /tmp/packages/nginx-module-${module}_${NGINX_VERSION}*.deb; \
6568
done \
6669
&& rm -rf /tmp/packages \

modules/Dockerfile.alpine

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,24 +44,27 @@ RUN set -ex \
4444
/modules/$module/prebuild; \
4545
fi; \
4646
/pkg-oss/build_module.sh -v $NGINX_VERSION -f -y -o /tmp/packages -n $module $(cat /modules/$module/source); \
47+
BUILT_MODULES="$BUILT_MODULES $(echo $module | tr '[A-Z]' '[a-z]' | tr -d '[/_\-\.\t ]')"; \
4748
elif make -C /pkg-oss/alpine list | grep -E "^$module\s+\d+" > /dev/null; then \
4849
echo "Building $module from pkg-oss sources"; \
4950
cd /pkg-oss/alpine; \
5051
make abuild-module-$module BASE_VERSION=$NGINX_VERSION NGINX_VERSION=$NGINX_VERSION; \
5152
apk add $(. ./abuild-module-$module/APKBUILD; echo $makedepends;); \
5253
make module-$module BASE_VERSION=$NGINX_VERSION NGINX_VERSION=$NGINX_VERSION; \
5354
find ~/packages -type f -name "*.apk" -exec mv -v {} /tmp/packages/ \;; \
55+
BUILT_MODULES="$BUILT_MODULES $module"; \
5456
else \
5557
echo "Don't know how to build $module module, exiting"; \
5658
exit 1; \
5759
fi; \
58-
done
60+
done \
61+
&& echo "BUILT_MODULES=\"$BUILT_MODULES\"" > /tmp/packages/modules.env
5962

6063
FROM nginx:mainline-alpine
61-
ARG ENABLED_MODULES
6264
COPY --from=builder /tmp/packages /tmp/packages
6365
RUN set -ex \
64-
&& for module in $ENABLED_MODULES; do \
66+
&& . /tmp/packages/modules.env \
67+
&& for module in $BUILT_MODULES; do \
6568
apk add --no-cache --allow-untrusted /tmp/packages/nginx-module-${module}-${NGINX_VERSION}*.apk; \
6669
done \
6770
&& rm -rf /tmp/packages

0 commit comments

Comments
 (0)