Phpstan errors (#163)

Author: Spomky

HS1.php

@@ -15,13 +15,13 @@
 
 final class HS1 extends HMAC
 {
-    protected function getHashAlgorithm(): string
+    public function name(): string
     {
-        return 'sha1';
+        return 'HS1';
     }
 
-    public function name(): string
+    protected function getHashAlgorithm(): string
     {
-        return 'HS1';
+        return 'sha1';
     }
 }

HS256_64.php

@@ -17,20 +17,20 @@
 
 final class HS256_64 extends HMAC
 {
-    protected function getHashAlgorithm(): string
-    {
-        return 'sha256';
-    }
-
     public function sign(JWK $key, string $input): string
     {
         $signature = parent::sign($key, $input);
 
-        return \mb_substr($signature, 0, 8, '8bit');
+        return mb_substr($signature, 0, 8, '8bit');
     }
 
     public function name(): string
     {
         return 'HS256/64';
     }
+
+    protected function getHashAlgorithm(): string
+    {
+        return 'sha256';
+    }
 }

RS1.php

@@ -17,6 +17,11 @@
 
 final class RS1 extends RSA
 {
+    public function name(): string
+    {
+        return 'RS1';
+    }
+
     protected function getAlgorithm(): string
     {
         return 'sha1';
@@ -26,9 +31,4 @@ protected function getSignatureMethod(): int
     {
         return JoseRSA::SIGNATURE_PKCS1;
     }
-
-    public function name(): string
-    {
-        return 'RS1';
-    }
 }

Tests/HMACSignatureTest.php

@@ -21,6 +21,9 @@
 /**
  * @group unit
  * @group NewAlgorithm
+ *
+ * @internal
+ * @coversNothing
  */
 class HMACSignatureTest extends TestCase
 {
@@ -53,13 +56,13 @@ public function hS256SignAndVerify()
 
         $signature = $hmac->sign($key, $data);
 
-        static::assertEquals(\hex2bin('89f750759cb8ad93'), $signature);
+        static::assertEquals(hex2bin('89f750759cb8ad93'), $signature);
         static::assertTrue($hmac->verify($key, $data, $signature));
     }
 
     private function getKey(): JWK
     {
-        return JWK::create([
+        return new JWK([
             'kty' => 'oct',
             'k' => 'foo',
         ]);

composer.json

@@ -31,6 +31,7 @@
             "v1.0": "1.0.x-dev",
             "v1.1": "1.1.x-dev",
             "v1.2": "1.2.x-dev",
+            "v1.3": "1.3.x-dev",
             "v2.0": "2.0.x-dev"
         }
     },