Skip to content

fix: remove classes before adding so docs-site class doesn’t conflict… #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmunns wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove classes before adding so docs-site class doesn’t conflict… #1716

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e043775
fix: remove classes before adding so docs-site class doesn’t conflict…
cmunns Aug 8, 2022
9a153d6
fix: remove effect and css selector for body that required body class…
cmunns Aug 8, 2022
e143283
fix: improve w3name section separator at large breakpoint
cmunns Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove effect and css selector for body that required body class… 
…list change
  • Loading branch information
@cmunns
cmunns committed Aug 8, 2022
commit 9a153d61ac39ee8b9d080483063d8a7eb8b4d1c5
5 changes: 0 additions & 5 deletions packages/website/pages/_app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ const App = ({ Component, pageProps }) => {
const productApp = productRoutes.includes(pathname);
const pageClass = pathname.includes('docs') ? 'docs-site' : productApp ? 'product-app' : 'marketing-site';

useEffect(() => {
document.querySelector('body')?.classList.remove('docs-site', 'product-app', 'marketing-site');
document.querySelector('body')?.classList.add(pageClass);
});

return (
<AppProviders authorizationProps={{ ...pageProps }}>
<Metadata {...pageProps} />
Expand Down
2 changes: 1 addition & 1 deletion packages/website/styles/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ button {
}

// Next & Grid
body:not(.docs-site) #__next {
body #__next {
position: relative;
z-index: 2;
overflow-x: hidden;
Expand Down