Fixes #1856 - Better error messaging for unset milestones

marimeireles · marimeireles · commit e3e0a9aa605d · 2018-11-09T21:54:00.000-02:00
diff --git a/webcompat/static/css/src/label-box.css b/webcompat/static/css/src/label-box.css
@@ -62,3 +62,13 @@
 .label-box-editor-button .nav-button {
   margin-top: var(--unit-gutter);
 }
+
+.is-logged-in .js-Milestone {
+  background-color: var(--label-color-bg-box-error-is-logged-in);
+}
+
+.is-logged-out .js-Milestone {
+  background-color: var(--base-background);
+  color: var(--label-color-is-logged-out);
+  font-weight: 700;
+}
diff --git a/webcompat/static/css/src/variables.css b/webcompat/static/css/src/variables.css
@@ -47,4 +47,6 @@
   --label-color-nsfw: rgba(221, 0, 0, 1); /* #DD0000 */
   --label-color-device: rgba(188, 143, 143, 1); /* rosybrown */
   --label-color-os: rgba(102, 51, 153, 1); /* rebeccapurple */
+  --label-color-bg-box-error-is-logged-in: rgba(255, 0, 0, 1); /* #ff0000 */
+  --label-color-is-logged-out: rgba(0, 0, 0, 1); /* #000000 */
 }
diff --git a/webcompat/static/js/lib/models/issue.js b/webcompat/static/js/lib/models/issue.js
@@ -52,9 +52,16 @@ issues.Issue = Backbone.Model.extend({
     return "Needs Triage";
   },
   parse: function(response) {
-    var milestone = response.milestone
-      ? response.milestone.title
-      : "Error: no status for this issue";
+    var milestone;
+    if (document.body.classList.contains("is-logged-in")) {
+      milestone = response.milestone
+        ? response.milestone.title
+        : "Fix me: assign a status";
+    } else {
+      milestone = response.milestone
+        ? response.milestone.title
+        : "No status assigned yet";
+    }
     var labelList = new issues.LabelList({ labels: response.labels });
     var labels = labelList.get("labels");
     this.set({
diff --git a/webcompat/templates/layout.html b/webcompat/templates/layout.html
@@ -33,7 +33,8 @@
   <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,600|Source+Sans+Pro:300,400|PT+Mono" rel="stylesheet">
   <link href="{{ url_for('static', filename='css/dist/webcompat.min.css') }}" type="text/css" rel="stylesheet">
 </head>
-<body id="body-webcompat" data-username="{{ session.username }}">
+<body id="body-webcompat" class="{{'is-logged-in' if session.username else 'is-logged-out'}}" data-username="{{ 
+session.username }}">
 {% include "shared/svg-icons.html" %}
 {% block body %}{% endblock %}
 {% include "shared/footer.html" %}

Original file line number	Diff line number	Diff line change
`@@ -47,4 +47,6 @@`
`47`	`47`	`--label-color-nsfw: rgba(221, 0, 0, 1); /* #DD0000 */`
`48`	`48`	`--label-color-device: rgba(188, 143, 143, 1); /* rosybrown */`
`49`	`49`	`--label-color-os: rgba(102, 51, 153, 1); /* rebeccapurple */`
	`50`	`+ --label-color-bg-box-error-is-logged-in: rgba(255, 0, 0, 1); /* #ff0000 */`
	`51`	`+ --label-color-is-logged-out: rgba(0, 0, 0, 1); /* #000000 */`
`50`	`52`	`}`