Add .ts extensions to Node test runner entries (#1121)

Co-authored-by: Lars Kappert <[email protected]>

Author: MidnightDesign

packages/knip/src/plugins/node/index.ts

@@ -15,8 +15,14 @@ const resolveConfig: ResolveConfig<PackageJson> = localConfig => {
 
   const entries = [toProductionEntry('server.js')];
 
-  if (scripts && Object.keys(scripts).some(script => /(?<=^|\s)node\s(.*)--test/.test(scripts[script]))) {
-    const patterns = ['**/*{.,-,_}test.?(c|m)js', '**/test-*.?(c|m)js', '**/test.?(c|m)js', '**/test/**/*.?(c|m)js'];
+  if (scripts && Object.values(scripts).some(script => /(?<=^|\s)node\s(.*)--test/.test(script))) {
+    // From https://nodejs.org/api/test.html#running-tests-from-the-command-line
+    const patterns = [
+      '**/*{.,-,_}test.{cjs,mjs,js,cts,mts,ts}',
+      '**/test-*.{cjs,mjs,js,cts,mts,ts}',
+      '**/test.{cjs,mjs,js,cts,mts,ts}',
+      '**/test/**/*.{cjs,mjs,js,cts,mts,ts}',
+    ];
     entries.push(...patterns.map(id => toEntry(id)));
   }
 

packages/knip/src/plugins/tsx/index.ts

@@ -20,7 +20,7 @@ const resolveConfig: ResolveConfig<PackageJson> = localConfig => {
 
   const entries = [];
 
-  if (scripts && Object.keys(scripts).some(script => /(?<=^|\s)tsx\s(.*)--test/.test(scripts[script]))) {
+  if (scripts && Object.values(scripts).some(script => /(?<=^|\s)tsx\s(.*)--test/.test(script))) {
     const patterns = [
       '**/*{.,-,_}test.?(c|m)(j|t)s',
       '**/test-*.?(c|m)(j|t)s',

packages/knip/src/plugins/vitest/index.ts

@@ -24,11 +24,7 @@ const entry = ['**/*.{bench,test,test-d,spec}.?(c|m)[jt]s?(x)', ...mocks];
 const isVitestCoverageCommand = /vitest(.+)--coverage(?:\.enabled(?:=true)?)?/;
 
 const hasScriptWithCoverage = (scripts: PackageJson['scripts']) =>
-  scripts
-    ? Object.values(scripts).some(script => {
-        return isVitestCoverageCommand.test(script);
-      })
-    : false;
+  scripts ? Object.values(scripts).some(script => isVitestCoverageCommand.test(script)) : false;
 
 const findConfigDependencies = (localConfig: ViteConfig, options: PluginOptions) => {
   const { manifest, cwd: dir } = options;