flexible to set ttl for each executeRequest

Author: tamnguyenit

src/main/java/com/wego/httpcache/services/AsyncHttpCacheService.java

@@ -9,4 +9,7 @@
 public interface AsyncHttpCacheService {
   Optional<ListenableFuture<Response>> executeRequest(
       Request request, AsyncCompletionHandlerBase handler) throws Exception;
+
+  Optional<ListenableFuture<Response>> executeRequest(
+      Request request, AsyncCompletionHandlerBase handler, long ttl) throws Exception;
 }

src/main/java/com/wego/httpcache/services/impl/AsyncHttpCacheServiceImpl.java

@@ -32,6 +32,12 @@ public AsyncHttpCacheServiceImpl(@Assisted AsyncHttpClient asyncHttpClient, @Ass
   @Override
   public Optional<ListenableFuture<Response>> executeRequest(
       Request request, AsyncCompletionHandlerBase handler) throws Exception {
+    return executeRequest(request, handler, ttl);
+  }
+
+  @Override
+  public Optional<ListenableFuture<Response>> executeRequest(
+      Request request, AsyncCompletionHandlerBase handler, long ttl) throws Exception {
 
     ListenableFuture<Response> responseListenableFuture = null;
     String responseId = buildResponseId(request);
@@ -42,7 +48,8 @@ public Optional<ListenableFuture<Response>> executeRequest(
       handler.onCompleted(cachedResponse.get());
     } else {
       responseListenableFuture =
-          this.asyncHttpClient.executeRequest(request, buildCachingHandler(handler, responseId));
+          this.asyncHttpClient.executeRequest(
+              request, buildCachingHandler(handler, responseId, ttl));
     }
 
     return Optional.ofNullable(responseListenableFuture);
@@ -58,14 +65,14 @@ private String buildResponseId(Request request) {
   }
 
   private AsyncCompletionHandlerBase buildCachingHandler(
-      final AsyncCompletionHandlerBase handler, final String responseId) {
+      final AsyncCompletionHandlerBase handler, final String responseId, final long cachingTtl) {
 
     return new AsyncCompletionHandlerBase() {
       @Override
       public Response onCompleted(Response response) throws Exception {
         CachedResponse cachedResponse =
             new CachedResponse.Builder(response).setId(responseId).build();
-        cachedResponseService.save(cachedResponse, ttl);
+        cachedResponseService.save(cachedResponse, cachingTtl);
 
         return handler.onCompleted(response);
       }

src/test/java/com/wego/httpcache/services/impl/TestAsyncHttpCachedServiceImpl.java

@@ -112,6 +112,41 @@ public void executeRequest_whenWasNotCached_executeHttpRequestAndCacheNewRespons
     assertThat(savedCachedResponses.get(0).getId()).isNotEmpty();
   }
 
+  @Test
+  public void executeRequest_withTtl_whenWasNotCached_executeHttpRequestAndCacheNewResponse()
+      throws Exception {
+    final Request request =
+        new RequestBuilder().setMethod("GET").setUrl("http://localhost:8089/resources/").build();
+    final List<CachedResponse> savedCachedResponses = Lists.newArrayList();
+    final long customTtl = 10;
+
+    stubFor(
+        get(urlEqualTo("/resources/"))
+            .willReturn(
+                aResponse()
+                    .withStatus(200)
+                    .withHeader("Content-Type", "text/json")
+                    .withBody("This is body")));
+
+    when(cachedResponseService.findById(anyString())).thenReturn(Optional.empty());
+    when(cachedResponseService.save(any(), eq(customTtl)))
+        .thenAnswer(
+            invocation -> {
+              CachedResponse cr = invocation.getArgumentAt(0, CachedResponse.class);
+              savedCachedResponses.add(cr);
+              return Optional.of(cr);
+            });
+
+    Optional<ListenableFuture<Response>> responseListenableFuture =
+        asyncHttpCacheService.executeRequest(request, new AsyncCompletionHandlerBase(), customTtl);
+
+    responseListenableFuture.get().get();
+
+    verify(asyncHttpClient).executeRequest(any(), any());
+    assertThat(savedCachedResponses.size()).isEqualTo(1);
+    assertThat(savedCachedResponses.get(0).getId()).isNotEmpty();
+  }
+
   @Test
   public void buildResponseId_returnsDifferentIdsForDifferentRequest() throws Exception {