[FIX] refactoring using sonarlint

Author: heowc

SpringBootAOP/src/main/java/com/example/SpringBootAopApplication.java

@@ -2,7 +2,6 @@
 
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
-import org.springframework.context.annotation.EnableAspectJAutoProxy;
 
 @SpringBootApplication
 public class SpringBootAopApplication {

SpringBootAsync/src/main/java/com/example/service/BasicService.java

@@ -11,21 +11,13 @@ public class BasicService {
 	private static final Logger logger = LoggerFactory.getLogger(BasicService.class);
 
 	@Async
-	public void onAsync() {
-		try {
-			Thread.sleep(1000);
-			logger.info("onAsync");
-		} catch (InterruptedException e) {
-			e.printStackTrace();
-		}
+	public void onAsync() throws InterruptedException {
+		Thread.sleep(1000);
+		logger.info("onAsync");
 	}
 
-	public void onSync() {
-		try {
-			Thread.sleep(1000);
-			logger.info("onSync");
-		} catch (InterruptedException e) {
-			e.printStackTrace();
-		}
+	public void onSync() throws InterruptedException {
+		Thread.sleep(1000);
+		logger.info("onSync");
 	}
 }

SpringBootBatch/src/main/java/com/heowc/EndOfDayJobConfig.java

@@ -16,20 +16,17 @@
 @Configuration
 public class EndOfDayJobConfig {
 
-    @Autowired
-    private JobBuilderFactory jobBuilderFactory;
-
     @Autowired
     private StepBuilderFactory stepBuilderFactory;
 
     @Bean
-    public Job endOfDay() {
+    public Job endOfDay(JobBuilderFactory jobBuilderFactory) {
         JobExecutionDecider decider = (jobExecution, stepExecution) -> {
             ExitStatus status = execute() ? ExitStatus.COMPLETED : ExitStatus.FAILED;
             return new FlowExecutionStatus(status.getExitCode());
         };
 
-        return this.jobBuilderFactory.get("endOfDay")
+        return jobBuilderFactory.get("endOfDay")
                 .start(step1())
                 .next(decider).on(ExitStatus.COMPLETED.getExitCode()).to(step2()) // *, ?
                 .from(decider).on(ExitStatus.FAILED.getExitCode()).stopAndRestart(step3()) // to(step3())

SpringBootBatch/src/main/java/com/heowc/SimpleJobLauncherController.java

@@ -3,7 +3,11 @@
 import org.springframework.batch.core.Job;
 import org.springframework.batch.core.JobParameter;
 import org.springframework.batch.core.JobParameters;
+import org.springframework.batch.core.JobParametersInvalidException;
 import org.springframework.batch.core.launch.JobLauncher;
+import org.springframework.batch.core.repository.JobExecutionAlreadyRunningException;
+import org.springframework.batch.core.repository.JobInstanceAlreadyCompleteException;
+import org.springframework.batch.core.repository.JobRestartException;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -26,7 +30,7 @@ public SimpleJobLauncherController(JobLauncher jobLauncher, Job job) {
     }
 
     @RequestMapping("/jobLauncher.html")
-    public void handle() throws Exception {
+    public void handle() throws JobParametersInvalidException, JobExecutionAlreadyRunningException, JobRestartException, JobInstanceAlreadyCompleteException {
         Map<String, JobParameter> map = new HashMap<>();
         map.put("create_date", new JobParameter(new Date()));
         jobLauncher.run(job, new JobParameters(map));

SpringBootConfigurable/src/main/java/com/heowc/account/Account.java

@@ -2,7 +2,6 @@
 
 import org.apache.commons.lang3.RandomStringUtils;
 import org.springframework.beans.factory.annotation.Autowire;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Configurable;
 import org.springframework.security.crypto.password.PasswordEncoder;
 

SpringBootCors/src/main/java/com/tistory/heowc/domain/Message.java

@@ -9,4 +9,12 @@ public Message(String sender, String content) {
 		this.sender = sender;
 		this.content = content;
 	}
+
+	public String getSender() {
+		return sender;
+	}
+
+	public String getContent() {
+		return content;
+	}
 }

SpringBootCustomJackson/src/main/java/com/example/web/BasicController.java

@@ -1,19 +1,23 @@
 package com.example.web;
 
 import com.example.domain.Model;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RestController;
 
 import java.util.ArrayList;
+import java.util.List;
 
 @RestController
 public class BasicController {
 
+	private static final Logger logger = LoggerFactory.getLogger(BasicController.class);
 	@GetMapping("/se")
-	public ArrayList<Model> index() {
-		ArrayList<Model> list = new ArrayList<Model>();
+	public List<Model> index() {
+		List<Model> list = new ArrayList<>();
 		list.add(new Model("abc", 1));
 		list.add(new Model("def", 2));
 		list.add(new Model("ghi", 3));
@@ -28,8 +32,8 @@ public ArrayList<Model> index() {
 	}
 
 	@PostMapping("/de")
-	public ArrayList<Model> deIndex(@RequestBody ArrayList<Model> deList) {
-		System.out.println(deList);
+	public List<Model> deIndex(@RequestBody List<Model> deList) {
+		logger.info(deList.toString());
 		return deList;
 	}
 }

SpringBootDynamo/src/main/java/com/example/DynamoDBConfig.java

@@ -1,9 +1,7 @@
 package com.example;
 
 import com.amazonaws.auth.AWSStaticCredentialsProvider;
-import com.amazonaws.auth.AnonymousAWSCredentials;
 import com.amazonaws.auth.BasicAWSCredentials;
-import com.amazonaws.auth.DefaultAWSCredentialsProviderChain;
 import com.amazonaws.client.builder.AwsClientBuilder;
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDB;
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDBClientBuilder;

SpringBootException/src/main/java/com/tistory/heowc/domain/ErrorInfo.java

@@ -3,10 +3,18 @@
 public class ErrorInfo {
 
 	private final String url;
-	private final String ex;
+	private final String message;
 
 	public ErrorInfo(String url, Exception ex) {
 		this.url = url;
-		this.ex = ex.getMessage();
+		this.message = ex.getMessage();
+	}
+
+	public String getUrl() {
+		return url;
+	}
+
+	public String getMessage() {
+		return message;
 	}
 }

SpringBootException/src/main/java/com/tistory/heowc/exception/ExtensionException.java

@@ -6,7 +6,7 @@
 @ResponseStatus(value = HttpStatus.NOT_FOUND)
 public class ExtensionException extends RuntimeException {
 
-	private String message;
+	private final String message;
 
 	public ExtensionException(String message) {
 		this.message = message;