Fix order-of-execution bug when generating pages (#5822)

natemoo-re · web-flow · commit 01f3f463bf29 · 2023-01-11T08:51:50.000-06:00
* fix: bundle all pages into a single chunk

* chore: add changeset

Co-authored-by: Nate Moore &lt;nate@astro.build&gt;
diff --git a/.changeset/beige-beds-smile.md b/.changeset/beige-beds-smile.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix edge case with bundle generation by emitting a single chunk for pages
diff --git a/packages/astro/src/core/build/vite-plugin-prerender.ts b/packages/astro/src/core/build/vite-plugin-prerender.ts
@@ -34,8 +34,8 @@ export function vitePluginPrerender(
 					if (api.getModuleInfo(id)?.meta.astro?.pageOptions?.prerender) {
 						return `prerender`;
 					}
-					// pages should go in their own chunks/pages/* directory
-					return `pages${pageInfo.route.route.replace(/\/$/, '/index')}`;
+					// dynamic pages should all go in their own chunk in the pages/* directory
+					return `pages/all`;
 				}
 			};
 		},

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'astro': patch
 +---
++
 +Fix edge case with bundle generation by emitting a single chunk for pages
Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ export function vitePluginPrerender(`
`34`	`34`	`if (api.getModuleInfo(id)?.meta.astro?.pageOptions?.prerender) {`
`35`	`35`	return `prerender`;
`36`	`36`	`}`
`37`		`- // pages should go in their own chunks/pages/* directory`
`38`		- return `pages${pageInfo.route.route.replace(/\/$/, '/index')}`;
	`37`	`+ // dynamic pages should all go in their own chunk in the pages/* directory`
	`38`	+ return `pages/all`;
`39`	`39`	`}`
`40`	`40`	`};`
`41`	`41`	`},`