Drop Node 14 support (#5782)

* chore: Update engines field

* fix(deps): Remove node-fetch

* feat(polyfills): Remove node-fetch for undici

* feat(webapi): Remove node-fetch from the webapis polyfills for undici

* feat(core): Remove node-fetch for undici in Astro core

* feat(telemetry): Remove node-fetch for undici

* feat(node): Remove node-fetch for undici in node integration

* feat(vercel): Remove node-fetch for undici in Vercel integration

* chore: update lockfile

* chore: update lockfile

* chore: changeset

* fix(set): Fix set directives not streaming correctly on Node 16

* Try another approach

* Debugging

* Debug fetch

* Use global fetch if there is one

* changeset for lit

* Remove web-streams-polyfill

* Remove web-streams-polyfill license note

* Update .changeset/stupid-wolves-explain.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

Author: 3 people

.changeset/chatty-rivers-camp.md

@@ -0,0 +1,5 @@
+---
+'@astrojs/lit': patch
+---
+
+Only shim fetch if not already present

.changeset/curvy-beds-warn.md

@@ -0,0 +1,16 @@
+---
+'astro': major
+'@astrojs/prism': major
+'create-astro': major
+'@astrojs/mdx': minor
+'@astrojs/node': major
+'@astrojs/preact': major
+'@astrojs/react': major
+'@astrojs/solid-js': major
+'@astrojs/svelte': major
+'@astrojs/vercel': major
+'@astrojs/vue': major
+'@astrojs/telemetry': major
+---
+
+Remove support for Node 14. Minimum supported Node version is now >=16.12.0

.changeset/stupid-wolves-explain.md

@@ -0,0 +1,7 @@
+---
+'@astrojs/webapi': major
+---
+
+Replace node-fetch's polyfill with undici.
+
+Since `undici` does not support it, this change also removes custom support for the `file:` protocol

packages/astro-prism/package.json

@@ -35,6 +35,6 @@
     "@types/prismjs": "1.26.0"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }

packages/astro/astro.js

@@ -50,7 +50,7 @@ async function main() {
 	// it's okay to hard-code the valid Node versions here since they will not change over time.
 	if (typeof require === 'undefined') {
 		console.error(`\nNode.js v${version} is not supported by Astro!
-Please upgrade to a version of Node.js with complete ESM support: "^14.18.0 || >=16.12.0"\n`);
+Please upgrade to a supported version of Node.js: ">=16.12.0"\n`);
 	}
 
 	// Not supported: Report the most helpful error message possible.

packages/astro/package.json

@@ -199,7 +199,6 @@
     "eol": "^0.9.1",
     "memfs": "^3.4.7",
     "mocha": "^9.2.2",
-    "node-fetch": "^3.2.5",
     "node-mocks-http": "^1.11.0",
     "rehype-autolink-headings": "^6.1.1",
     "rehype-slug": "^5.0.1",
@@ -208,10 +207,11 @@
     "rollup": "^3.9.0",
     "sass": "^1.52.2",
     "srcset-parse": "^1.1.0",
+    "undici": "^5.14.0",
     "unified": "^10.1.2"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0",
+    "node": ">=16.12.0",
     "npm": ">=6.14.0"
   }
 }

packages/astro/src/runtime/server/escape.ts

@@ -1,4 +1,5 @@
 import { escape } from 'html-escaper';
+import { streamAsyncIterator } from './util.js';
 
 // Leverage the battle-tested `html-escaper` npm package.
 export const escapeHTML = escape;
@@ -58,9 +59,19 @@ export function isHTMLBytes(value: any): value is HTMLBytes {
 	return Object.prototype.toString.call(value) === '[object HTMLBytes]';
 }
 
-async function* unescapeChunksAsync(iterable: AsyncIterable<Uint8Array>): any {
-	for await (const chunk of iterable) {
-		yield unescapeHTML(chunk as BlessedType);
+function hasGetReader(obj: unknown): obj is ReadableStream {
+	return typeof (obj as any).getReader === 'function';
+}
+
+async function* unescapeChunksAsync(iterable: ReadableStream | string): any {
+	if (hasGetReader(iterable)) {
+		for await (const chunk of streamAsyncIterator(iterable)) {
+			yield unescapeHTML(chunk as BlessedType);
+		}
+	} else {
+		for await (const chunk of iterable) {
+			yield unescapeHTML(chunk as BlessedType);
+		}
 	}
 }
 
@@ -82,7 +93,7 @@ export function unescapeHTML(
 		}
 		// If a response, stream out the chunks
 		else if (str instanceof Response && str.body) {
-			const body = str.body as unknown as AsyncIterable<Uint8Array>;
+			const body = str.body;
 			return unescapeChunksAsync(body);
 		}
 		// If a promise, await the result and mark that.
@@ -92,7 +103,7 @@ export function unescapeHTML(
 			});
 		} else if (Symbol.iterator in str) {
 			return unescapeChunks(str);
-		} else if (Symbol.asyncIterator in str) {
+		} else if (Symbol.asyncIterator in str || hasGetReader(str)) {
 			return unescapeChunksAsync(str);
 		}
 	}

packages/astro/src/runtime/server/response.ts

@@ -1,3 +1,5 @@
+import { streamAsyncIterator } from './util.js';
+
 const isNodeJS =
 	typeof process === 'object' && Object.prototype.toString.call(process) === '[object process]';
 
@@ -21,9 +23,9 @@ function createResponseClass() {
 		async text(): Promise<string> {
 			if (this.#isStream && isNodeJS) {
 				let decoder = new TextDecoder();
-				let body = this.#body as AsyncIterable<Uint8Array>;
+				let body = this.#body;
 				let out = '';
-				for await (let chunk of body) {
+				for await (let chunk of streamAsyncIterator(body)) {
 					out += decoder.decode(chunk);
 				}
 				return out;
@@ -33,10 +35,10 @@ function createResponseClass() {
 
 		async arrayBuffer(): Promise<ArrayBuffer> {
 			if (this.#isStream && isNodeJS) {
-				let body = this.#body as AsyncIterable<Uint8Array>;
+				let body = this.#body;
 				let chunks: Uint8Array[] = [];
 				let len = 0;
-				for await (let chunk of body) {
+				for await (let chunk of streamAsyncIterator(body)) {
 					chunks.push(chunk);
 					len += chunk.length;
 				}

packages/astro/src/runtime/server/util.ts

@@ -31,3 +31,17 @@ export function serializeListValue(value: any) {
 export function isPromise<T = any>(value: any): value is Promise<T> {
 	return !!value && typeof value === 'object' && typeof value.then === 'function';
 }
+
+export async function* streamAsyncIterator(stream: ReadableStream) {
+	const reader = stream.getReader();
+
+	try {
+		while (true) {
+			const { done, value } = await reader.read();
+			if (done) return;
+			yield value;
+		}
+	} finally {
+		reader.releaseLock();
+	}
+}

packages/astro/test/ssr-api-route.test.js

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
-import { loadFixture } from './test-utils.js';
+import { File, FormData } from 'undici';
 import testAdapter from './test-adapter.js';
-import { FormData, File } from 'node-fetch';
+import { loadFixture } from './test-utils.js';
 
 describe('API routes in SSR', () => {
 	/** @type {import('./test-utils').Fixture} */