PR comments

Author: matthewp

packages/astro/src/core/build/app.ts

@@ -1,6 +1,5 @@
 import { BaseApp, type RenderErrorOptions } from '../app/index.js';
 import type { SSRManifest } from '../app/types.js';
-import type { Logger } from '../logger/core.js';
 import type { BuildInternals } from './internal.js';
 import { BuildPipeline } from './pipeline.js';
 import type { StaticBuildOptions } from './types.js';
@@ -12,16 +11,13 @@ export class BuildApp extends BaseApp<BuildPipeline> {
 		});
 	}
 
-	setLogger(logger: Logger) {
-		this.logger = logger;
-	}
-
 	public setInternals(internals: BuildInternals) {
 		this.pipeline.setInternals(internals);
 	}
 
 	public setOptions(options: StaticBuildOptions) {
 		this.pipeline.setOptions(options);
+		this.logger = options.logger;
 	}
 
 	public getOptions() {

packages/astro/src/core/build/generate.ts

@@ -57,7 +57,6 @@ export async function generatePages(
 	const app = prerenderEntry.app as BuildApp;
 	app.setInternals(internals);
 	app.setOptions(options);
-	app.setLogger(options.logger);
 
 	const logger = app.logger;
 

packages/astro/src/core/build/static-build.ts

@@ -280,11 +280,13 @@ async function buildEnvironments(opts: StaticBuildOptions, internals: BuildInter
 	// and this is the only way to update the input after instantiation.
 	internals.clientInput = getClientInput(internals, settings);
 	if(!internals.clientInput.size) {
+		// At least 1 input is required to do a build, otherwise Vite throws.
+		// We need the client build to happen in order to copy over the `public/` folder
+		// So using the noop plugin here which will give us an input that just gets thrown away.
 		internals.clientInput.add(NOOP_MODULE_ID);
 	}
 	builder.environments.client.config.build.rollupOptions.input = Array.from(internals.clientInput);
-	const clientOutput =
-		internals.clientInput.size === 0 ? [] : await builder.build(builder.environments.client);
+	const clientOutput = await builder.build(builder.environments.client);
 
 	return { ssrOutput, prerenderOutput, clientOutput };
 }