Skip to content

Conversation

@trueberryless
Copy link
Contributor

Description

Follow up of #3390 which updates the dark screenshot of the Starlight Galaxy Theme to not have a visible scrollbar included. This is very nitpicky, I'm sorry. And I'm also sorry for not noticing this when reviewing because GitHub mobile does not want to show images...

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2025

⚠️ No Changeset found

Latest commit: f09291d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 24, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f09291d
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/68ab58bc1d5a080008b35d94
😎 Deploy Preview https://deploy-preview-3395--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Aug 24, 2025
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s basically invisible, so not surprised you didn’t spot it 😁

For the record, I don’t think the scrollbar matters too much either way, but thanks for the update!

@delucis delucis merged commit b7e03ee into withastro:main Aug 25, 2025
17 checks passed
@trueberryless trueberryless deleted the galaxy-dark-without-scrollbar branch August 25, 2025 09:49
@trueberryless
Copy link
Contributor Author

It’s basically invisible, so not surprised you didn’t spot it 😁

Yeah, the changes of this PR are also kinda invisible 😅

Screenshot_20250825-115047.png

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 26, 2025
* main: (55 commits)
  i18n(de): translate `themes.mdx` (withastro#3397)
  [ci] format
  i18n(ko): translate `themes.mdx` (withastro#3398)
  [ci] format
  docs: add Starlight Page to themes showcase (withastro#3393)
  i18n(de): update German themes (withastro#3394)
  docs: change image of Starlight Galaxy Theme dark image to not include a visible scrollbar (withastro#3395)
  [ci] format
  i18n(ko-KR): update `themes.mdx` (withastro#3392)
  [ci] format
  Add link to new Starlight theme (withastro#3390)
  i18n(fr): update `guides/css-and-tailwind.mdx` (withastro#3389)
  i18n(de): translate `guides/css-and-tailwind.mdx` (withastro#3386)
  [ci] format
  i18n(ko-KR): update `css-and-tailwind.mdx` (withastro#3388)
  Adds OmniPrint documentation to the showcase (withastro#3387)
  docs(showcase): Add Aptos Docs (withastro#3385)
  docs: add section about multiple Tailwind configs (withastro#3273)
  Add basic ESLint config, lint script and lint CI job (withastro#1640)
  chore(deps): update actions/checkout action to v5 (withastro#3375)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 27, 2025
* main: (137 commits)
  i18n(fr): update `resources/themes.mdx` (withastro#3399)
  i18n(de): translate `themes.mdx` (withastro#3397)
  [ci] format
  i18n(ko): translate `themes.mdx` (withastro#3398)
  [ci] format
  docs: add Starlight Page to themes showcase (withastro#3393)
  i18n(de): update German themes (withastro#3394)
  docs: change image of Starlight Galaxy Theme dark image to not include a visible scrollbar (withastro#3395)
  [ci] format
  i18n(ko-KR): update `themes.mdx` (withastro#3392)
  [ci] format
  Add link to new Starlight theme (withastro#3390)
  i18n(fr): update `guides/css-and-tailwind.mdx` (withastro#3389)
  i18n(de): translate `guides/css-and-tailwind.mdx` (withastro#3386)
  [ci] format
  i18n(ko-KR): update `css-and-tailwind.mdx` (withastro#3388)
  Adds OmniPrint documentation to the showcase (withastro#3387)
  docs(showcase): Add Aptos Docs (withastro#3385)
  docs: add section about multiple Tailwind configs (withastro#3273)
  Add basic ESLint config, lint script and lint CI job (withastro#1640)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants