Skip to content

Convert invalid <div> child of <summary> to <span> #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2025
Merged

Convert invalid <div> child of <summary> to <span> #3422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54b73e
Convert invalid <div> child of <summary> to <span>
andersk Sep 11, 2025
8f9c92f
Add changeset
delucis Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-rocks-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/starlight': patch
---

Converted invalid `<div>` child of `<summary>` to `<span>`
4 changes: 2 additions & 2 deletions packages/starlight/components/MobileTableOfContents.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const { toc } = Astro.locals.starlightRoute;
<nav aria-labelledby="starlight__on-this-page--mobile">
<details id="starlight__mobile-toc">
<summary id="starlight__on-this-page--mobile" class="sl-flex">
<div class="toggle sl-flex">
<span class="toggle sl-flex">
{Astro.locals.t('tableOfContents.onThisPage')}
<Icon name={'right-caret'} class="caret" size="1rem" />
</div>
</span>
<span class="display-current" />
</summary>
<div class="dropdown">
Expand Down
4 changes: 2 additions & 2 deletions packages/starlight/components/SidebarSublist.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const { sublist, nested } = Astro.props;
>
<SidebarRestorePoint />
<summary>
<div class="group-label">
<span class="group-label">
<span class="large">{entry.label}</span>
{entry.badge && (
<Badge
Expand All @@ -48,7 +48,7 @@ const { sublist, nested } = Astro.props;
text={entry.badge.text}
/>
)}
</div>
</span>
<Icon name="right-caret" class="caret" size="1.25rem" />
</summary>
<Astro.self sublist={entry.entries} nested />
Expand Down
Loading