Skip to content

Fix file filters added in #3520 #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2025
Merged

Fix file filters added in #3520 #3522

merged 3 commits into from
Nov 3, 2025

Conversation

@delucis
Copy link
Member

@delucis delucis commented Nov 3, 2025

Description

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 16d26e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 3, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 16d26e7
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6908cae1aaf75500088188c1
😎 Deploy Preview https://deploy-preview-3522--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🚨 action Changes to GitHub Action workflows label Nov 3, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
/index.html 7.29 KB (0%)
/_astro/*.js 25.76 KB (0%)
/_astro/*.css 14.29 KB (0%)

@delucis delucis marked this pull request as ready for review November 3, 2025 11:56
@HiDeoo
Copy link
Member

HiDeoo commented Nov 3, 2025

Wow, I totally missed that too 🙈

I think this may be because it's missing the jobs.changes.outputs for docs_ja, docs_en, and docs_not_content. I remember forgetting them last time too in 7c18d61 (#3433)

@delucis
Copy link
Member Author

delucis commented Nov 3, 2025

I think this may be because it's missing the jobs.changes.outputs for docs_ja, docs_en, and docs_not_content. I remember forgetting them last time too in 7c18d61 (#3433)

Ohhhh, yes! I wasn’t expecting to have to specify it twice. Thanks for remembering that.

I even was wondering why I had yellow squigglies for the new filters but not the old one in the editor (thanks to the GitHub Actions VS Code extension), but didn’t join the dots.

Pushed up a change adding those!

delucis
delucis commented Nov 3, 2025
View reviewed changes
HiDeoo
HiDeoo approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized I forgot to approve this one earlier.

Looks good to me (altho the previous one also looked good to me 😅).

@delucis delucis merged commit 0cfa009 into main Nov 3, 2025
16 checks passed
@delucis delucis deleted the chris/fix-a11y-skip branch November 3, 2025 17:30
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 5, 2025
@HiDeoo
Merge branch 'main' into hd-remark-rehype-refactor
712d1f9 
* main: (47 commits)
  feat: add some of trueberryless' new Starlight blogs to community content (withastro#3525)
  i18n(fr): update `resources/themes` (withastro#3526)
  Fix file filters added in withastro#3520 (withastro#3522)
  i18n(fr): update `guides/site-search.mdx` (withastro#3524)
  i18n(fr): update `resources/plugins.mdx` (withastro#3523)
  docs: add starlight-themes link (withastro#3510)
  i18n(de): update translation resources/plugins.mdx (withastro#3519)
  i18n(de): update translation guides/site-search.mdx (withastro#3518)
  Skip a11y CI checks for docs changes that aren’t tested anyway (withastro#3520)
  Speed up Linux e2e tests (withastro#3517)
  i18n(ru): update translations (withastro#3512)
  Tweak a11y e2e tests (withastro#3507)
  [ci] format
  docs(plugin): starlight-docsearch-typesense (withastro#3504)
  Add starlight-page-actions (withastro#3515)
  ci: update file icons (withastro#3511)
  [i18nIgnore] Match title case convention for components/using-components (withastro#3508)
  Disable Prettier on GitHub Actions workflow files (withastro#3509)
  [ci] release (withastro#3490)
  Update release workflow for OIDC (withastro#3500)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

🚨 action Changes to GitHub Action workflows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delucis @astrobot-houston @HiDeoo