Commit 4a88428
committed
pkg/cvo/sync_worker: TaskNodeComplete events during updates
Only during updates, because:
* Install-time is a free-for-all, where the CVO doesn't block on
anything. This would be a lot of "node complete" noise about nodes
where we had only attempted to push manifests, and that's unlikely
to be what event-readers expect TaskNodeComplete to imply.
* Reconcile-time hopefully has very few instances where the CVO needs
to stomp on changes, block on a recently Available=False operator,
etc. Eventing on each completed TaskNode would be lots of noise
without much interesting signal.
During updates, we have the structured graph and blocking TaskNodes
described in docs/user/reconciliation.md, and the flow through that
graph is what the events from this commit will help shed light on.
You could also achieve this by preserving logs from the CVO pods as
they are repositioned throughout an update, but we don't have tooling
in CI to do that conveniently today.
The hardcoded name and namespace for cvoObjectRef isn't great (for
example, it won't work in pkg/start/start_integration_test.go , where
the ClusterVersion's name and namespace are random). But it's the
pattern we've used since we started eventing in 475e71f (emit
events for each new payload, 2020-07-21, openshift#411), so I'm recylcing it
for now.1 parent 71aef74 commit 4a88428
1 file changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
704 | 704 | | |
705 | 705 | | |
706 | 706 | | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
707 | 711 | | |
708 | 712 | | |
709 | 713 | | |
| |||
0 commit comments