Merge pull request scala#3365 from retronym/ticket/8133

 Fix regression with package objects, overloading

Author: retronym

src/compiler/scala/tools/nsc/typechecker/Typers.scala

@@ -555,7 +555,7 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper
         }
         val qual = typedQualifier { atPos(tree.pos.makeTransparent) {
           tree match {
-            case Ident(_) => Ident(nme.PACKAGEkw)
+            case Ident(_) => Ident(rootMirror.getPackageObjectWithMember(pre, sym))
             case Select(qual, _) => Select(qual, nme.PACKAGEkw)
             case SelectFromTypeTree(qual, _) => Select(qual, nme.PACKAGEkw)
           }

src/reflect/scala/reflect/internal/Mirrors.scala

@@ -186,6 +186,15 @@ trait Mirrors extends api.Mirrors {
 
     def getPackageObjectIfDefined(fullname: TermName): Symbol =
       wrapMissing(getPackageObject(fullname))
+    
+    final def getPackageObjectWithMember(pre: Type, sym: Symbol): Symbol = {
+      // The owner of a symbol which requires package qualification may be the
+      // package object iself, but it also could be any superclass of the package
+      // object.  In the latter case, we must go through the qualifier's info
+      // to obtain the right symbol.
+      if (sym.owner.isModuleClass) sym.owner.sourceModule // fast path, if the member is owned by a module class, that must be linked to the package object 
+      else pre member nme.PACKAGE                         // otherwise we have to findMember
+    }
 
     override def staticPackage(fullname: String): ModuleSymbol =
       ensurePackageSymbol(fullname.toString, getModuleOrClass(newTermNameCached(fullname)), allowModules = false)

src/reflect/scala/reflect/internal/TreeGen.scala

@@ -191,11 +191,7 @@ abstract class TreeGen extends macros.TreeBuilder {
       )
       val pkgQualifier =
         if (needsPackageQualifier) {
-          // The owner of a symbol which requires package qualification may be the
-          // package object iself, but it also could be any superclass of the package
-          // object.  In the latter case, we must go through the qualifier's info
-          // to obtain the right symbol.
-          val packageObject = if (sym.owner.isModuleClass) sym.owner.sourceModule else qual.tpe member nme.PACKAGE
+          val packageObject = rootMirror.getPackageObjectWithMember(qual.tpe, sym)
           Select(qual, nme.PACKAGE) setSymbol packageObject setType singleType(qual.tpe, packageObject)
         }
         else qual

test/files/run/t8133/A_1.scala

@@ -0,0 +1,5 @@
+//  a.scala
+package object pkg {
+  class AnyOps(val x: Any) extends AnyVal
+  def AnyOps(x: Any) = new AnyOps(x)
+}

test/files/run/t8133/B_2.scala

@@ -0,0 +1,15 @@
+package pkg { 
+  package object other
+  package other {
+    class Crash { 
+      AnyOps(0)
+      ()
+    }
+  }
+}
+ 
+object Test {
+  def main(args: Array[String]): Unit = {
+    new pkg.other.Crash
+  }
+}

test/files/run/t8133b/A_1.scala

@@ -0,0 +1,4 @@
+package object pkg {
+  def foo(x: Int): String = "a"
+  def foo(x: String): String = "b"
+}

test/files/run/t8133b/B_2.scala

@@ -0,0 +1,9 @@
+//  b.scala
+package pkg {
+  package object other
+  package other { class Crash { foo("") } }
+}
+ 
+object Test {
+  def main(args: Array[String]): Unit = new pkg.other.Crash
+}