Skip to content

Commit 04fa09a

Browse files
committed
[Style] added backface-visibility. fixes facebook#1973
Summary: default behavior remains same(backface visible). cc @sahrens Closes facebook#1977 Github Author: chirag04 <[email protected]>
1 parent 5d4140c commit 04fa09a

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

Libraries/Components/View/ViewStylePropTypes.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var TransformPropTypes = require('TransformPropTypes');
2121
var ViewStylePropTypes = {
2222
...LayoutPropTypes,
2323
...TransformPropTypes,
24+
backfaceVisibility: ReactPropTypes.oneOf(['visible', 'hidden']),
2425
backgroundColor: ReactPropTypes.string,
2526
borderColor: ReactPropTypes.string,
2627
borderTopColor: ReactPropTypes.string,

React/Base/RCTConvert.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@ typedef NSArray CGColorArray;
120120
typedef id NSPropertyList;
121121
+ (NSPropertyList)NSPropertyList:(id)json;
122122

123-
typedef BOOL css_clip_t;
123+
typedef BOOL css_clip_t, css_backface_visibility_t;
124124
+ (css_clip_t)css_clip_t:(id)json;
125+
+ (css_backface_visibility_t)css_backface_visibility_t:(id)json;
125126
+ (css_flex_direction_t)css_flex_direction_t:(id)json;
126127
+ (css_justify_t)css_justify_t:(id)json;
127128
+ (css_align_t)css_align_t:(id)json;

React/Base/RCTConvert.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,6 +993,11 @@ + (NSPropertyList)NSPropertyList:(id)json
993993
return RCTConvertPropertyListValue(json);
994994
}
995995

996+
RCT_ENUM_CONVERTER(css_backface_visibility_t, (@{
997+
@"hidden": @NO,
998+
@"visible": @YES
999+
}), YES, boolValue)
1000+
9961001
RCT_ENUM_CONVERTER(css_clip_t, (@{
9971002
@"hidden": @YES,
9981003
@"visible": @NO

React/Views/RCTViewManager.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(__unused RCTSpars
9696
RCT_EXPORT_VIEW_PROPERTY(backgroundColor, UIColor)
9797
RCT_REMAP_VIEW_PROPERTY(accessible, isAccessibilityElement, BOOL)
9898
RCT_REMAP_VIEW_PROPERTY(testID, accessibilityIdentifier, NSString)
99+
RCT_REMAP_VIEW_PROPERTY(backfaceVisibility, layer.doubleSided, css_backface_visibility_t)
99100
RCT_REMAP_VIEW_PROPERTY(opacity, alpha, CGFloat)
100101
RCT_REMAP_VIEW_PROPERTY(shadowColor, layer.shadowColor, CGColor);
101102
RCT_REMAP_VIEW_PROPERTY(shadowOffset, layer.shadowOffset, CGSize);

0 commit comments

Comments
 (0)