Improve the performance of React Native tests

Author: ndfred

Examples/UIExplorer/UIExplorerUnitTests/RCTAllocationTests.m

@@ -19,17 +19,15 @@
 #import "RCTContextExecutor.h"
 #import "RCTRootView.h"
 
-#define RUN_RUNLOOP_WHILE(CONDITION, TIMEOUT) \
+#define RUN_RUNLOOP_WHILE(CONDITION) \
 _Pragma("clang diagnostic push") \
 _Pragma("clang diagnostic ignored \"-Wshadow\"") \
-NSDate *timeout = [[NSDate date] dateByAddingTimeInterval:TIMEOUT]; \
+NSDate *timeout = [[NSDate date] dateByAddingTimeInterval:0.1]; \
 while ((CONDITION) && [timeout timeIntervalSinceNow] > 0) { \
   [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:timeout]; \
 } \
 _Pragma("clang diagnostic pop")
 
-#define DEFAULT_TIMEOUT 2
-
 @interface RCTBridge (RCTAllocationTests)
 
 @property (nonatomic, weak) RCTBridge *batchedBridge;
@@ -83,7 +81,6 @@ - (void)testBridgeIsDeallocated
     (void)view;
   }
 
-  sleep(DEFAULT_TIMEOUT);
   XCTAssertNil(weakBridge, @"RCTBridge should have been deallocated");
 }
 
@@ -104,8 +101,7 @@ - (void)testModulesAreInvalidated
    * Sleep on the main thread to allow js thread deallocations then run the runloop
    * to allow the module to be deallocated on the main thread
    */
-  sleep(1);
-  RUN_RUNLOOP_WHILE(module.isValid, 1)
+  RUN_RUNLOOP_WHILE(module.isValid)
   XCTAssertFalse(module.isValid, @"AllocationTestModule should have been invalidated by the bridge");
 }
 
@@ -124,12 +120,7 @@ - (void)testModulesAreDeallocated
     (void)bridge;
   }
 
-  /**
-   * Sleep on the main thread to allow js thread deallocations then run the runloop
-   * to allow the module to be deallocated on the main thread
-   */
-  sleep(1);
-  RUN_RUNLOOP_WHILE(weakModule, 1)
+  RUN_RUNLOOP_WHILE(weakModule)
   XCTAssertNil(weakModule, @"AllocationTestModule should have been deallocated");
 }
 
@@ -145,8 +136,7 @@ - (void)testJavaScriptExecutorIsDeallocated
     (void)bridge;
   }
 
-  RUN_RUNLOOP_WHILE(weakExecutor, 1);
-  sleep(1);
+  RUN_RUNLOOP_WHILE(weakExecutor);
   XCTAssertNil(weakExecutor, @"JavaScriptExecutor should have been released");
 }
 
@@ -158,13 +148,12 @@ - (void)testJavaScriptContextIsDeallocated
                                               moduleProvider:nil
                                                launchOptions:nil];
     id executor = [bridge.batchedBridge valueForKey:@"javaScriptExecutor"];
-    RUN_RUNLOOP_WHILE(!(weakContext = [executor valueForKey:@"context"]), DEFAULT_TIMEOUT);
+    RUN_RUNLOOP_WHILE(!(weakContext = [executor valueForKey:@"context"]));
     XCTAssertNotNil(weakContext, @"RCTJavaScriptContext should have been created");
     (void)bridge;
   }
 
-  RUN_RUNLOOP_WHILE(weakContext, 1);
-  sleep(1);
+  RUN_RUNLOOP_WHILE(weakContext);
   XCTAssertNil(weakContext, @"RCTJavaScriptContext should have been deallocated");
 }
 
@@ -176,12 +165,11 @@ - (void)testContentViewIsInvalidated
   __weak id rootContentView;
   @autoreleasepool {
     RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge moduleName:@""];
-    RUN_RUNLOOP_WHILE(!(rootContentView = [rootView valueForKey:@"contentView"]), DEFAULT_TIMEOUT)
+    RUN_RUNLOOP_WHILE(!(rootContentView = [rootView valueForKey:@"contentView"]))
     XCTAssertTrue([rootContentView isValid], @"RCTContentView should be valid");
     (void)rootView;
   }
 
-  sleep(DEFAULT_TIMEOUT);
   XCTAssertFalse([rootContentView isValid], @"RCTContentView should have been invalidated");
 }
 
@@ -196,8 +184,7 @@ - (void)testUnderlyingBridgeIsDeallocated
     [bridge reload];
   }
 
-  // Use RUN_RUNLOOP_WHILE because `batchedBridge` deallocates on the main thread.
-  RUN_RUNLOOP_WHILE(batchedBridge != nil, DEFAULT_TIMEOUT)
+  RUN_RUNLOOP_WHILE(batchedBridge != nil)
 
   XCTAssertNotNil(bridge, @"RCTBridge should not have been deallocated");
   XCTAssertNil(batchedBridge, @"RCTBatchedBridge should have been deallocated");

Examples/UIExplorer/UIExplorerUnitTests/RCTContextExecutorTests.m

@@ -19,6 +19,7 @@
 #import "RCTContextExecutor.h"
 #import "RCTUtils.h"
 
+#define RUN_PERF_TESTS 0
 
 @interface RCTContextExecutorTests : XCTestCase
 
@@ -48,6 +49,8 @@ - (void)testNativeLoggingHookExceptionBehavior
   [_executor invalidate];
 }
 
+#if RUN_PERF_TESTS
+
 static uint64_t _get_time_nanoseconds(void)
 {
   static struct mach_timebase_info tb_info = {0, 0};
@@ -91,7 +94,7 @@ - (void)testDeserializationPerf
   JSContextGroupRelease(group);
 }
 
-- (void)MANUALLY_testJavaScriptCallSpeed
+- (void)testJavaScriptCallSpeed
 {
 /**
  * Since we almost don't change the RCTContextExecutor logic, and this test is
@@ -200,4 +203,6 @@ function require(module) { \
   }
 }
 
+#endif
+
 @end