Skip to content

Commit 949a38c

Browse files
committed
Merge branch 'mkirk/fix-dismiss-kb-after-send'
2 parents f305b2c + 11fa084 commit 949a38c

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Podfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ target 'Signal' do
77
#pod 'AxolotlKit', path: '../SignalProtocolKit'
88
pod 'SignalServiceKit', git: 'https://github.com/WhisperSystems/SignalServiceKit.git'
99
#pod 'SignalServiceKit', path: '../SignalServiceKit'
10-
pod 'JSQMessagesViewController', git: 'https://github.com/WhisperSystems/JSQMessagesViewController.git', branch: 'mkirk/position-edit-menu'
11-
#pod 'JSQMessagesViewController' path: '../JSQMessagesViewController'
10+
pod 'JSQMessagesViewController', git: 'https://github.com/WhisperSystems/JSQMessagesViewController.git', branch: 'mkirk/retain-keyboard-view'
11+
#pod 'JSQMessagesViewController', path: '../JSQMessagesViewController'
1212
pod 'PureLayout'
1313
pod 'Reachability'
1414
target 'SignalTests' do

Podfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ PODS:
109109

110110
DEPENDENCIES:
111111
- AxolotlKit (from `https://github.com/WhisperSystems/SignalProtocolKit.git`)
112-
- JSQMessagesViewController (from `https://github.com/WhisperSystems/JSQMessagesViewController.git`, branch `mkirk/position-edit-menu`)
112+
- JSQMessagesViewController (from `https://github.com/WhisperSystems/JSQMessagesViewController.git`, branch `mkirk/retain-keyboard-view`)
113113
- PureLayout
114114
- Reachability
115115
- SignalServiceKit (from `https://github.com/WhisperSystems/SignalServiceKit.git`)
@@ -119,7 +119,7 @@ EXTERNAL SOURCES:
119119
AxolotlKit:
120120
:git: https://github.com/WhisperSystems/SignalProtocolKit.git
121121
JSQMessagesViewController:
122-
:branch: mkirk/position-edit-menu
122+
:branch: mkirk/retain-keyboard-view
123123
:git: https://github.com/WhisperSystems/JSQMessagesViewController.git
124124
SignalServiceKit:
125125
:git: https://github.com/WhisperSystems/SignalServiceKit.git
@@ -131,7 +131,7 @@ CHECKOUT OPTIONS:
131131
:commit: f8f44d143bffd38e8470fdca0db7adf73a844956
132132
:git: https://github.com/WhisperSystems/SignalProtocolKit.git
133133
JSQMessagesViewController:
134-
:commit: 7054e4b13ee5bcd6d524adb6dc9a726e8c466308
134+
:commit: 521686c112bbae7a762f85d52b1e41eeb1760772
135135
:git: https://github.com/WhisperSystems/JSQMessagesViewController.git
136136
SignalServiceKit:
137137
:commit: ed249840c61ab48a7fcd762d7d4b01dc78dff0a6
@@ -161,6 +161,6 @@ SPEC CHECKSUMS:
161161
UnionFind: c33be5adb12983981d6e827ea94fc7f9e370f52d
162162
YapDatabase: cd911121580ff16675f65ad742a9eb0ab4d9e266
163163

164-
PODFILE CHECKSUM: 89fd7aee1e2b0ca592ecc9dba0389e57b70f959b
164+
PODFILE CHECKSUM: 01734aea935bf91b25ee9aed90e20403075e5d19
165165

166166
COCOAPODS: 1.2.1

Signal/src/ViewControllers/ConversationView/MessagesViewController.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1497,6 +1497,8 @@ - (void)toggleDefaultKeyboard
14971497
if (![self.inputToolbar.contentView.textView.textInputMode primaryLanguage]) {
14981498
return;
14991499
}
1500+
1501+
// The JSQ event listeners cause a bounce animation, so we temporarily disable them.
15001502
[self.keyboardController endListeningForKeyboard];
15011503
[self dismissKeyBoard];
15021504
[self popKeyBoard];

0 commit comments

Comments
 (0)