Merge branch 'charlesmchen/moreScrollDownButton'

Author: charlesmchen

Signal/src/ViewControllers/ConversationView/MessagesViewController.m

@@ -2793,6 +2793,7 @@ - (void)viewDidLayoutSubviews
     [super viewDidLayoutSubviews];
 
     [self updateLastVisibleTimestamp];
+    [self ensureScrollDownButton];
 }
 
 - (void)createScrollDownButton
@@ -2838,13 +2839,23 @@ - (void)ensureScrollDownButton
 
     BOOL shouldShowScrollDownButton = NO;
     NSUInteger numberOfMessages = [self.messageMappings numberOfItemsInSection:0];
+    CGFloat scrollSpaceToBottom = (self.collectionView.contentSize.height + self.collectionView.contentInset.bottom
+        - (self.collectionView.contentOffset.y + self.collectionView.frame.size.height));
+    CGFloat pageHeight = (self.collectionView.frame.size.height
+        - (self.collectionView.contentInset.top + self.collectionView.contentInset.bottom));
+    // Show "scroll down" button if user is scrolled up at least
+    // one page.
+    BOOL isScrolledUp = scrollSpaceToBottom > pageHeight * 1.f;
+
     if (numberOfMessages > 0) {
         TSInteraction *lastInteraction =
             [self interactionAtIndexPath:[NSIndexPath indexPathForRow:(NSInteger)numberOfMessages - 1 inSection:0]];
         OWSAssert(lastInteraction);
 
         if (lastInteraction.timestampForSorting > self.lastVisibleTimestamp) {
             shouldShowScrollDownButton = YES;
+        } else if (isScrolledUp) {
+            shouldShowScrollDownButton = YES;
         }
     }
 
@@ -3992,7 +4003,7 @@ - (void)showErrorAlertForAttachment:(SignalAttachment *_Nullable)attachment
     [self presentViewController:controller animated:YES completion:nil];
 }
 
-- (void)textViewDidChangePosition
+- (void)textViewDidChangeLayout
 {
     OWSAssert([NSThread isMainThread]);
 
@@ -4006,6 +4017,8 @@ - (void)textViewDidChangePosition
                                                                    userInfo:nil
                                                                     repeats:NO];
     }
+
+    [self ensureScrollDownButton];
 }
 
 - (void)scrollToBottomImmediately
@@ -4096,6 +4109,8 @@ - (void)textViewDidChange:(UITextView *)textView
     // We want to show the "voice message" button if the text input is empty
     // and the "send" button if it isn't.
     [((OWSMessagesToolbarContentView *)self.inputToolbar.contentView)ensureEnabling];
+
+    [self ensureScrollDownButton];
 }
 
 #pragma mark - UIScrollViewDelegate
@@ -4162,7 +4177,6 @@ - (void)popAllConversationSettingsViews
 
 #pragma mark - OWSMessagesCollectionViewFlowLayoutDelegate
 
-
 - (BOOL)shouldShowCellDecorationsAtIndexPath:(NSIndexPath *)indexPath
 {
     TSInteraction *interaction = [self interactionAtIndexPath:indexPath];

Signal/src/ViewControllers/ConversationView/OWSMessagesComposerTextView.h

@@ -12,7 +12,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)didPasteAttachment:(SignalAttachment *_Nullable)attachment;
 
-- (void)textViewDidChangePosition;
+- (void)textViewDidChangeLayout;
 
 @end
 

Signal/src/ViewControllers/ConversationView/OWSMessagesComposerTextView.m

@@ -19,7 +19,7 @@ - (BOOL)becomeFirstResponder
     BOOL becameFirstResponder = [super becomeFirstResponder];
     if (becameFirstResponder) {
         // Intercept to scroll to bottom when text view is tapped.
-        [self.textViewPasteDelegate textViewDidChangePosition];
+        [self.textViewPasteDelegate textViewDidChangeLayout];
     }
     return becameFirstResponder;
 }
@@ -61,7 +61,7 @@ - (void)setFrame:(CGRect)frame
     [super setFrame:frame];
 
     if (didChangeSize && isNonEmpty) {
-        [self.textViewPasteDelegate textViewDidChangePosition];
+        [self.textViewPasteDelegate textViewDidChangeLayout];
     }
 }
 
@@ -73,7 +73,7 @@ - (void)setBounds:(CGRect)bounds
     [super setBounds:bounds];
 
     if (didChangeSize && isNonEmpty) {
-        [self.textViewPasteDelegate textViewDidChangePosition];
+        [self.textViewPasteDelegate textViewDidChangeLayout];
     }
 }