Skip to content

Commit eff1974

Browse files
committed
[SSK] Reduce chattiness of logs; increase log file sizes.
// FREEBIE
1 parent 1ae7f07 commit eff1974

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed

Podfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ target 'Signal' do
55
pod 'SocketRocket', :git => 'https://github.com/facebook/SocketRocket.git'
66
pod 'AxolotlKit', git: 'https://github.com/WhisperSystems/SignalProtocolKit.git'
77
#pod 'AxolotlKit', path: '../SignalProtocolKit'
8-
pod 'SignalServiceKit', git: 'https://github.com/WhisperSystems/SignalServiceKit.git'
9-
#pod 'SignalServiceKit', path: '../SignalServiceKit'
8+
#pod 'SignalServiceKit', git: 'https://github.com/WhisperSystems/SignalServiceKit.git'
9+
pod 'SignalServiceKit', path: '../SignalServiceKit'
1010
pod 'JSQMessagesViewController', git: 'https://github.com/WhisperSystems/JSQMessagesViewController.git', branch: 'mkirk/retain-keyboard-view'
1111
#pod 'JSQMessagesViewController', path: '../JSQMessagesViewController'
1212
pod 'PureLayout'

Podfile.lock

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ DEPENDENCIES:
112112
- JSQMessagesViewController (from `https://github.com/WhisperSystems/JSQMessagesViewController.git`, branch `mkirk/retain-keyboard-view`)
113113
- PureLayout
114114
- Reachability
115-
- SignalServiceKit (from `https://github.com/WhisperSystems/SignalServiceKit.git`)
115+
- SignalServiceKit (from `../SignalServiceKit`)
116116
- SocketRocket (from `https://github.com/facebook/SocketRocket.git`)
117117

118118
EXTERNAL SOURCES:
@@ -122,7 +122,7 @@ EXTERNAL SOURCES:
122122
:branch: mkirk/retain-keyboard-view
123123
:git: https://github.com/WhisperSystems/JSQMessagesViewController.git
124124
SignalServiceKit:
125-
:git: https://github.com/WhisperSystems/SignalServiceKit.git
125+
:path: ../SignalServiceKit
126126
SocketRocket:
127127
:git: https://github.com/facebook/SocketRocket.git
128128

@@ -133,9 +133,6 @@ CHECKOUT OPTIONS:
133133
JSQMessagesViewController:
134134
:commit: 521686c112bbae7a762f85d52b1e41eeb1760772
135135
:git: https://github.com/WhisperSystems/JSQMessagesViewController.git
136-
SignalServiceKit:
137-
:commit: 4609c508ec51c69af171ea227eca7ac010f065d5
138-
:git: https://github.com/WhisperSystems/SignalServiceKit.git
139136
SocketRocket:
140137
:commit: 877ac7438be3ad0b45ef5ca3969574e4b97112bf
141138
:git: https://github.com/facebook/SocketRocket.git
@@ -161,6 +158,6 @@ SPEC CHECKSUMS:
161158
UnionFind: c33be5adb12983981d6e827ea94fc7f9e370f52d
162159
YapDatabase: cd911121580ff16675f65ad742a9eb0ab4d9e266
163160

164-
PODFILE CHECKSUM: 01734aea935bf91b25ee9aed90e20403075e5d19
161+
PODFILE CHECKSUM: 2088b6153dfaf0ce79fdf9141c7885c1ab84dd2b
165162

166163
COCOAPODS: 1.2.1

Signal/src/ViewControllers/ConversationView/MessagesViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3592,7 +3592,7 @@ - (void)cancelRecordingVoiceMemo
35923592
{
35933593
OWSAssert([NSThread isMainThread]);
35943594

3595-
DDLogInfo(@"cancelRecordingVoiceMemo");
3595+
DDLogDebug(@"cancelRecordingVoiceMemo");
35963596

35973597
[self resetRecordingVoiceMemo];
35983598
}

Signal/src/environment/DebugLogger.m

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
//
2-
// DebugLogger.m
3-
// Signal
4-
//
5-
// Created by Frederic Jacobs on 08/08/14.
6-
// Copyright (c) 2014 Open Whisper Systems. All rights reserved.
2+
// Copyright (c) 2017 Open Whisper Systems. All rights reserved.
73
//
84

95
#import "DebugLogger.h"
@@ -30,10 +26,14 @@ + (instancetype)sharedLogger {
3026

3127

3228
- (void)enableFileLogging {
33-
self.fileLogger = [[DDFileLogger alloc]
34-
init]; // Logging to file, because it's in the Cache folder, they are not uploaded in iTunes/iCloud backups.
35-
self.fileLogger.rollingFrequency = 60 * 60 * 24; // 24 hour rolling.
36-
self.fileLogger.logFileManager.maximumNumberOfLogFiles = 3; // Keep three days of logs.
29+
// Logging to file, because it's in the Cache folder, they are not uploaded in iTunes/iCloud backups.
30+
self.fileLogger = [DDFileLogger new];
31+
// 24 hour rolling.
32+
self.fileLogger.rollingFrequency = 60 * 60 * 24;
33+
// Keep last 3 days of logs - or last 3 logs (if logs rollover due to max file size).
34+
self.fileLogger.logFileManager.maximumNumberOfLogFiles = 3;
35+
// Raise the max file size per log file to 3 MB.
36+
self.fileLogger.maximumFileSize = 1024 * 1024 * 3;
3737
self.fileLogger.logFormatter = [OWSScrubbingLogFormatter new];
3838

3939
[DDLog addLogger:self.fileLogger];

0 commit comments

Comments
 (0)