Respond to CR.

charlesmchen · charlesmchen · commit f3f832557fdf · 2017-06-21T10:39:45.000-04:00
// FREEBIE
diff --git a/Signal/src/environment/Migrations/OWS105AttachmentFilePaths.m b/Signal/src/environment/Migrations/OWS105AttachmentFilePaths.m
@@ -34,6 +34,9 @@ - (void)runUpWithTransaction:(YapDatabaseReadWriteTransaction *)transaction
 
     DDLogInfo(@"Saving %zd attachment streams.", attachmentStreams.count);
 
+    // Persist the new localRelativeFilePath property of TSAttachmentStream.
+    // For performance, we want to upgrade all existing attachment streams in
+    // a single transaction.
     for (TSAttachmentStream *attachmentStream in attachmentStreams) {
         [attachmentStream saveWithTransaction:transaction];
     }

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,9 @@ - (void)runUpWithTransaction:(YapDatabaseReadWriteTransaction *)transaction`
`34`	`34`
`35`	`35`	`DDLogInfo(@"Saving %zd attachment streams.", attachmentStreams.count);`
`36`	`36`
	`37`	`+ // Persist the new localRelativeFilePath property of TSAttachmentStream.`
	`38`	`+ // For performance, we want to upgrade all existing attachment streams in`
	`39`	`+ // a single transaction.`
`37`	`40`	`for (TSAttachmentStream *attachmentStream in attachmentStreams) {`
`38`	`41`	`[attachmentStream saveWithTransaction:transaction];`
`39`	`42`	`}`