Merge branch 'charlesmchen/invalidateMessageAdapterCache'

Author: charlesmchen

Signal/src/ViewControllers/ConversationView/MessagesViewController.m

@@ -561,6 +561,8 @@ - (void)viewWillAppear:(BOOL)animated
     // or on another device.
     [self hideInputIfNeeded];
 
+    self.messageAdapterCache = [[NSCache alloc] init];
+
     // We need to `beginLongLivedReadTransaction` before we update our
     // mapping in order to jump to the most recent commit.
     [self.uiDatabaseConnection beginLongLivedReadTransaction];
@@ -3306,6 +3308,7 @@ - (void)yapDatabaseModified:(NSNotification *)notification
                     [self.collectionView deleteItemsAtIndexPaths:@[ rowChange.indexPath ]];
 
                     YapCollectionKey *collectionKey = rowChange.collectionKey;
+                    OWSAssert(collectionKey.key.length > 0);
                     if (collectionKey.key) {
                         [self.messageAdapterCache removeObjectForKey:collectionKey.key];
                     }
@@ -3329,6 +3332,7 @@ - (void)yapDatabaseModified:(NSNotification *)notification
                 }
                 case YapDatabaseViewChangeUpdate: {
                     YapCollectionKey *collectionKey = rowChange.collectionKey;
+                    OWSAssert(collectionKey.key.length > 0);
                     if (collectionKey.key) {
                         [self.messageAdapterCache removeObjectForKey:collectionKey.key];
                     }