Headers as part of Client

[RozeFound]

For example, i have the code: https://pastebin.com/8tRuhSUn
And i really don`t think that downloadFile func need to care about headers.

With headers as part of Client the following functions will have view like:

main() {
   Client session(scheme_host);
   session.headers = {...};

   someFunc(session); //etc
}

Seens much better, you don't think so?

[yhirose]

@RozeFound, thanks for the feedback. The cpp-httplib client API is similar to the way that cpr does, and this API gives flexibility to each request.

But I understand your situation that you don't want to set the same header entries again every time you send another request. So I am thinking to add something like Client::set_default_headers(Headers headers).

[yhirose]

Could you try the version on this branch?

[RozeFound]

@yhirose yup, it's work fine for me, but you forgot add constructor without headers for Get overload with response handler, content receiver and progress.

[RozeFound]

The cpp-httplib client API is similar to the way that cpr does, and this API gives flexibility to each request.

But cpr have a little bit different structure, it have session object, and also can make fully individual GET requests. Unlike cpp-httplib, wich have something between session, and individual requests.

[yhirose]

@RozeFound, thanks for the reply. What do you mean by "but you forgot add constructor without headers for Get overload with response handler, content receiver and progress"? Thanks.

[RozeFound]

What do you mean by "but you forgot add constructor without headers for Get overload with response handler, content receiver and progress"? Thanks.

@yhirose This:

You forgot

std::shared_ptr<Response> Get(const char* path,
            ResponseHandler response_handler,
            ContentReceiver content_receiver,
            Progress progress);

Or am I confusing something and everything is as it should be?

[yhirose]

@RozeFound, got it! I'll add the one. Thanks.