Skip to content

Commit 2e27078

Browse files
committed
Fixed checkstyle code quality issues
1 parent 1d9aff4 commit 2e27078

File tree

8 files changed

+29
-27
lines changed

8 files changed

+29
-27
lines changed

null-object/src/test/java/com/iluwatar/nullobject/TreeTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ public class TreeTest extends StdOutTest {
3232
private static final Node TREE_ROOT;
3333

3434
static {
35-
final NodeImpl level1_b = new NodeImpl("level1_b", NullNode.getInstance(), NullNode.getInstance());
36-
final NodeImpl level2_b = new NodeImpl("level2_b", NullNode.getInstance(), NullNode.getInstance());
37-
final NodeImpl level3_a = new NodeImpl("level3_a", NullNode.getInstance(), NullNode.getInstance());
38-
final NodeImpl level3_b = new NodeImpl("level3_b", NullNode.getInstance(), NullNode.getInstance());
39-
final NodeImpl level2_a = new NodeImpl("level2_a", level3_a, level3_b);
40-
final NodeImpl level1_a = new NodeImpl("level1_a", level2_a, level2_b);
41-
TREE_ROOT = new NodeImpl("root", level1_a, level1_b);
35+
final NodeImpl level1B = new NodeImpl("level1_b", NullNode.getInstance(), NullNode.getInstance());
36+
final NodeImpl level2B = new NodeImpl("level2_b", NullNode.getInstance(), NullNode.getInstance());
37+
final NodeImpl level3A = new NodeImpl("level3_a", NullNode.getInstance(), NullNode.getInstance());
38+
final NodeImpl level3B = new NodeImpl("level3_b", NullNode.getInstance(), NullNode.getInstance());
39+
final NodeImpl level2A = new NodeImpl("level2_a", level3A, level3B);
40+
final NodeImpl level1A = new NodeImpl("level1_a", level2A, level2B);
41+
TREE_ROOT = new NodeImpl("root", level1A, level1B);
4242
}
4343

4444
/**

poison-pill/src/test/java/com/iluwatar/poison/pill/ConsumerTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ public class ConsumerTest extends StdOutTest {
1717
@Test
1818
public void testConsume() throws Exception {
1919
final Message[] messages = new Message[]{
20-
createMessage("you", "Hello!"),
21-
createMessage("me", "Hi!"),
22-
Message.POISON_PILL,
23-
createMessage("late_for_the_party", "Hello? Anyone here?"),
20+
createMessage("you", "Hello!"),
21+
createMessage("me", "Hi!"),
22+
Message.POISON_PILL,
23+
createMessage("late_for_the_party", "Hello? Anyone here?"),
2424
};
2525

2626
final MessageQueue queue = new SimpleMessageQueue(messages.length);

private-class-data/src/test/java/com/iluwatar/privateclassdata/StewTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ public class StewTest extends StdOutTest {
1818
@Test
1919
public void testMix() {
2020
final ImmutableStew stew = new ImmutableStew(1, 2, 3, 4);
21-
final String expectedMessage = "Mixing the immutable stew we find: 1 potatoes, " +
22-
"2 carrots, 3 meat and 4 peppers";
21+
final String expectedMessage = "Mixing the immutable stew we find: 1 potatoes, "
22+
+ "2 carrots, 3 meat and 4 peppers";
2323

2424
final InOrder inOrder = inOrder(getStdOutMock());
2525
for (int i = 0; i < 20; i++) {

producer-consumer/src/test/java/com/iluwatar/producer/consumer/ConsumerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public void testConsume() throws Exception {
3030
for (int id = 0; id < ITEM_COUNT; id++) {
3131
consumer.consume();
3232
inOrder.verify(getStdOutMock())
33-
.println("Consumer [consumer] consume item [" + id + "] produced by [producer]");
33+
.println("Consumer [consumer] consume item [" + id + "] produced by [producer]");
3434
}
3535

3636
inOrder.verifyNoMoreInteractions();

proxy/src/test/java/com/iluwatar/proxy/WizardTowerProxyTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ public class WizardTowerProxyTest extends StdOutTest {
1515
@Test
1616
public void testEnter() throws Exception {
1717
final Wizard[] wizards = new Wizard[]{
18-
new Wizard("Gandalf"),
19-
new Wizard("Dumbledore"),
20-
new Wizard("Oz"),
21-
new Wizard("Merlin")
18+
new Wizard("Gandalf"),
19+
new Wizard("Dumbledore"),
20+
new Wizard("Oz"),
21+
new Wizard("Merlin")
2222
};
2323

2424
final WizardTowerProxy tower = new WizardTowerProxy();

proxy/src/test/java/com/iluwatar/proxy/WizardTowerTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ public class WizardTowerTest extends StdOutTest {
1515
@Test
1616
public void testEnter() throws Exception {
1717
final Wizard[] wizards = new Wizard[]{
18-
new Wizard("Gandalf"),
19-
new Wizard("Dumbledore"),
20-
new Wizard("Oz"),
21-
new Wizard("Merlin")
18+
new Wizard("Gandalf"),
19+
new Wizard("Dumbledore"),
20+
new Wizard("Oz"),
21+
new Wizard("Merlin")
2222
};
2323

2424
final WizardTower tower = new WizardTower();

service-locator/src/test/java/com/iluwatar/servicelocator/ServiceLocatorTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22

33
import org.junit.Test;
44

5-
import static org.junit.Assert.*;
5+
import static org.junit.Assert.assertEquals;
6+
import static org.junit.Assert.assertNotNull;
7+
import static org.junit.Assert.assertNull;
8+
import static org.junit.Assert.assertSame;
9+
import static org.junit.Assert.assertTrue;
610

711
/**
812
* Date: 12/29/15 - 19:07 PM
@@ -26,7 +30,7 @@ public void testGetNonExistentService() {
2630
@Test
2731
public void testServiceCache() {
2832
final String[] serviceNames = new String[]{
29-
"jndi/serviceA", "jndi/serviceB"
33+
"jndi/serviceA", "jndi/serviceB"
3034
};
3135

3236
for (final String serviceName : serviceNames) {

state/src/test/java/com/iluwatar/state/AppTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
package com.iluwatar.state;
22

3-
import org.junit.Ignore;
43
import org.junit.Test;
54

65
/**
7-
*
6+
*
87
* Application test
98
*
109
*/
1110
public class AppTest {
1211

1312
@Test
14-
@Ignore
1513
public void test() {
1614
String[] args = {};
1715
App.main(args);

0 commit comments

Comments
 (0)