Remove redis_cmd_append_str and redis_cmd_append_int

Author: michael-grunder

library.c

@@ -722,33 +722,6 @@ redis_cmd_format_static(char **ret, char *keyword, char *format, ...)
     return buf.len;
 }
 
-/*
- * Append a command sequence to a Redis command
- */
-int redis_cmd_append_str(char **cmd, int cmd_len, char *append, int append_len) {
-	/* Smart string buffer */
-	smart_string buf = {0};
-
-	/* Append the current command to our smart_string */
-	smart_string_appendl(&buf, *cmd, cmd_len);
-
-	/* Append our new command sequence */
-	smart_string_appendc(&buf, '$');
-	smart_string_append_long(&buf, append_len);
-	smart_string_appendl(&buf, _NL, sizeof(_NL) -1);
-	smart_string_appendl(&buf, append, append_len);
-	smart_string_appendl(&buf, _NL, sizeof(_NL) -1);
-
-	/* Free our old command */
-	efree(*cmd);
-
-	/* Set our return pointer */
-	*cmd = buf.c;
-
-	/* Return new command length */
-	return buf.len;
-}
-
 /*
  * Given a smart string, number of arguments, a keyword, and the length of the keyword
  * initialize our smart string with the proper Redis header for the command to follow
@@ -843,20 +816,6 @@ int redis_cmd_append_sstr_key(smart_string *str, char *key, strlen_t len, RedisS
     return retval;
 }
 
-/*
- * Append an integer command to a Redis command
- */
-int redis_cmd_append_int(char **cmd, int cmd_len, int append) {
-    char int_buf[32];
-    int int_len;
-
-    // Conver to an int, capture length
-    int_len = snprintf(int_buf, sizeof(int_buf), "%d", append);
-
-	/* Return the new length */
-	return redis_cmd_append_str(cmd, cmd_len, int_buf, int_len);
-}
-
 PHP_REDIS_API void redis_bulk_double_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock, zval *z_tab, void *ctx) {
 
     char *response;

library.h

@@ -15,12 +15,10 @@
 
 int integer_length(int i);
 int redis_cmd_format_static(char **ret, char *keyword, char *format, ...);
-int redis_cmd_append_str(char **cmd, int cmd_len, char *append, int append_len);
 int redis_cmd_init_sstr(smart_string *str, int num_args, char *keyword, int keyword_len);
 int redis_cmd_append_sstr(smart_string *str, char *append, int append_len);
 int redis_cmd_append_sstr_int(smart_string *str, int append);
 int redis_cmd_append_sstr_long(smart_string *str, long append);
-int redis_cmd_append_int(char **cmd, int cmd_len, int append);
 int redis_cmd_append_sstr_dbl(smart_string *str, double value);
 int redis_cmd_append_sstr_zval(smart_string *str, zval *z, RedisSock *redis_sock TSRMLS_DC);
 int redis_cmd_append_sstr_key(smart_string *str, char *key, strlen_t len, RedisSock *redis_sock, short *slot);