Merge pull request reugn#10 from reugn/develop

v0.3.3

Author: reugn

README.md

@@ -10,7 +10,7 @@ Simple, zero-dependency scheduling library for Go.
 Inspired by the [Quartz](https://github.com/quartz-scheduler/quartz) Java scheduler.
 
 ### Library building blocks
-Job interface. Should be implemented by custom jobs for further scheduling
+Job interface. Any type that implements it can be scheduled.
 ```go
 type Job interface {
 	Execute()
@@ -67,7 +67,7 @@ sched.ScheduleJob(shellJob, cronTrigger)
 sched.ScheduleJob(curlJob, quartz.NewSimpleTrigger(time.Second*7))
 sched.Stop()
 ```
-More code samples could be found in the examples directory.
+More code samples can be found in the examples directory.
 
 ## License
 Licensed under the MIT License.

quartz/scheduler_test.go

@@ -10,7 +10,7 @@ import (
 
 func TestScheduler(t *testing.T) {
 	sched := quartz.NewStdScheduler()
-	var jobKeys [2]int
+	var jobKeys [4]int
 
 	shellJob := quartz.NewShellJob("ls -la")
 	shellJob.Description()
@@ -21,13 +21,22 @@ func TestScheduler(t *testing.T) {
 	curlJob.Description()
 	jobKeys[1] = curlJob.Key()
 
+	errShellJob := quartz.NewShellJob("ls -z")
+	jobKeys[2] = errShellJob.Key()
+
+	errCurlJob, err := quartz.NewCurlJob(http.MethodGet, "http://", "", nil)
+	assertEqual(t, err, nil)
+	jobKeys[3] = errCurlJob.Key()
+
 	sched.Start()
 	sched.ScheduleJob(shellJob, quartz.NewSimpleTrigger(time.Millisecond*800))
 	sched.ScheduleJob(curlJob, quartz.NewRunOnceTrigger(time.Millisecond))
+	sched.ScheduleJob(errShellJob, quartz.NewRunOnceTrigger(time.Millisecond))
+	sched.ScheduleJob(errCurlJob, quartz.NewSimpleTrigger(time.Millisecond*800))
 
 	time.Sleep(time.Second)
 	scheduledJobKeys := sched.GetJobKeys()
-	assertEqual(t, scheduledJobKeys, []int{3059422767})
+	assertEqual(t, scheduledJobKeys, []int{3059422767, 328790344})
 
 	_, err = sched.GetScheduledJob(jobKeys[0])
 	if err != nil {
@@ -38,10 +47,15 @@ func TestScheduler(t *testing.T) {
 	if err != nil {
 		t.Fail()
 	}
-	assertEqual(t, sched.Queue.Len(), 0)
+
+	scheduledJobKeys = sched.GetJobKeys()
+	assertEqual(t, scheduledJobKeys, []int{328790344})
+	assertEqual(t, sched.Queue.Len(), 1)
 
 	sched.Clear()
 	sched.Stop()
 	assertEqual(t, shellJob.JobStatus, quartz.OK)
 	assertEqual(t, curlJob.JobStatus, quartz.OK)
+	assertEqual(t, errShellJob.JobStatus, quartz.FAILURE)
+	assertEqual(t, errCurlJob.JobStatus, quartz.FAILURE)
 }