Transform scalar markets from integer to fixed point numbers (#838)

* Remove previous migrations

* Migrate scalar markets to fixed point numbers

* Fix clippy issues

* Remove debug info

* Apply suggestions from code review

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Add note about scalar market transformation to docs

* Add explicit test for `range.start() != range.end()`

* Make noop test clearer

* Migrate `zrml_authorized`

* Remove comments

* Remove EOL from info string

* Revert unnecessary change & clean up

* Migrate votes in court

* Fix info string

* Add additional tests

* Fix migration benchmarks

Co-authored-by: Chralt <chralt.developer@gmail.com>

* Fix the count of reads on `Votes`

Co-authored-by: Chralt <chralt.developer@gmail.com>

Author: maltekliemann

docs/changelog_for_devs.md

@@ -1,5 +1,8 @@
 # v0.3.7
 
+- Transformed integer scalar markets to fixed point with ten digits after the
+  decimal point. As soon as this update is deployed, the interpretation of the
+  scalar values must be changed.
 - `reject_market` extrinsic now requires `reject_reason` parameter which is
   `Vec<u8>`. The config constant `MaxRejectReasonLen` defines maximum length of
   above parameter. `MarketRejected` event also contains `reject_reason` so that

runtime/common/src/lib.rs

@@ -58,13 +58,7 @@ macro_rules! decl_common_types {
             frame_system::ChainContext<Runtime>,
             Runtime,
             AllPalletsWithSystem,
-            (
-                pallet_author_mapping::migrations::AddKeysToRegistrationInfo<Runtime>,
-                pallet_author_mapping::migrations::AddAccountIdToNimbusLookup<Runtime>,
-                pallet_parachain_staking::migrations::SplitDelegatorStateIntoDelegationScheduledRequests<Runtime>,
-                zrml_prediction_markets::migrations::UpdateMarketsForDeadlines<Runtime>,
-                zrml_prediction_markets::migrations::MigrateMarketIdsPerBlockStorage<Runtime>,
-            )
+            zrml_prediction_markets::migrations::TransformScalarMarketsToFixedPoint<Runtime>,
         >;
 
         #[cfg(not(feature = "parachain"))]
@@ -74,10 +68,7 @@ macro_rules! decl_common_types {
             frame_system::ChainContext<Runtime>,
             Runtime,
             AllPalletsWithSystem,
-            (
-                zrml_prediction_markets::migrations::UpdateMarketsForDeadlines<Runtime>,
-                zrml_prediction_markets::migrations::MigrateMarketIdsPerBlockStorage<Runtime>,
-            )
+            zrml_prediction_markets::migrations::TransformScalarMarketsToFixedPoint<Runtime>,
         >;
 
         pub type Header = generic::Header<BlockNumber, BlakeTwo256>;

zrml/authorized/src/lib.rs

@@ -50,7 +50,7 @@ mod pallet {
     use zrml_market_commons::MarketCommonsPalletApi;
 
     /// The current storage version.
-    const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);
+    const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);
 
     pub(crate) type BalanceOf<T> =
         <CurrencyOf<T> as Currency<<T as frame_system::Config>::AccountId>>::Balance;

zrml/court/src/lib.rs

@@ -73,7 +73,7 @@ mod pallet {
     const INITIAL_JURORS_NUM: usize = 3;
     const MAX_RANDOM_JURORS: usize = 13;
     /// The current storage version.
-    const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);
+    const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);
     // Weight used to increase the number of jurors for subsequent disputes
     // of the same market
     const SUBSEQUENT_JURORS_FACTOR: usize = 2;

zrml/market-commons/src/lib.rs

@@ -48,7 +48,7 @@ mod pallet {
     use zeitgeist_primitives::types::{Market, PoolId};
 
     /// The current storage version.
-    const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);
+    const STORAGE_VERSION: StorageVersion = StorageVersion::new(3);
 
     pub type MomentOf<T> = <<T as Config>::Timestamp as frame_support::traits::Time>::Moment;
 

zrml/prediction-markets/src/lib.rs

@@ -67,7 +67,7 @@ mod pallet {
     use zrml_market_commons::MarketCommonsPalletApi;
 
     /// The current storage version.
-    const STORAGE_VERSION: StorageVersion = StorageVersion::new(5);
+    const STORAGE_VERSION: StorageVersion = StorageVersion::new(6);
 
     pub(crate) type BalanceOf<T> = <<T as Config>::AssetManager as MultiCurrency<
         <T as frame_system::Config>::AccountId,