Skip to content

Commit f3a5f24

Browse files
committed
style: 💄 code formating for Swift/AnniversaryCalculatorDemo
empty array init , use guard instead of "!", remove self and ";"
1 parent 9aefcd5 commit f3a5f24

File tree

5 files changed

+36
-43
lines changed

5 files changed

+36
-43
lines changed

Swift/AnniversaryCalculator/AnniversaryCalculatorDemo/Couple.swift

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,33 +12,33 @@ struct Couple {
1212
let anniversary: String
1313

1414
func shouldAnniversaryToRemind() -> Bool {
15-
if (self.anniversary.isEmpty || self.coupleId.isEmpty) {
16-
return false;
15+
if (anniversary.isEmpty || coupleId.isEmpty) {
16+
return false
1717
}
1818

19-
let anniversaryAtStr = self.anniversary
20-
var anniversaryAt: Date = Date.dateFromISOString(string: anniversaryAtStr) ?? Date();
21-
19+
let anniversaryAtStr = anniversary
20+
var anniversaryAt: Date = Date.dateFromISOString(string: anniversaryAtStr) ?? Date()
21+
2222
if anniversaryAt >= Date() {
2323
return false
2424
}
2525

26-
let gapYears: Int = Date.gapYears(date: anniversaryAt)
27-
26+
let gapYears: Int = Date.gapYears(date: anniversaryAt)
27+
2828
anniversaryAt = Date.thisYearDate(pastDate: anniversaryAt)
2929
if gapYears % 10 == 0 {
30-
anniversaryAt = anniversaryAt.afterDays(days: 14)
30+
anniversaryAt = anniversaryAt.after(days: 14)
3131
} else if gapYears % 5 == 0 {
32-
anniversaryAt = anniversaryAt.afterDays(days: 7)
32+
anniversaryAt = anniversaryAt.after(days: 7)
3333
}
34-
35-
let beginReminderDate = Date().afterDays(days: 1)
36-
let endReminderDate = Date().afterDays(days: 14)
3734

38-
if anniversaryAt <= endReminderDate && anniversaryAt >= beginReminderDate {
35+
let beginReminderDate = Date().after(days: 1)
36+
let endReminderDate = Date().after(days: 14)
37+
38+
if anniversaryAt <= endReminderDate && anniversaryAt >= beginReminderDate {
3939
return true
4040
}
41-
return false;
41+
return false
4242
}
4343

4444
}

Swift/AnniversaryCalculator/AnniversaryCalculatorDemo/DateExtension.swift

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,15 @@ extension Date {
2525
return dateFormatter.date(from: string)
2626
}
2727

28-
func afterDays(days: Int) -> Date {
29-
var dayComponent = DateComponents()
30-
dayComponent.day = days // For removing one day (yesterday): -1
31-
let theCalendar = Calendar.current
32-
let nextDate : Date = theCalendar.date(byAdding: dayComponent, to: Date())!
33-
28+
func after(days: Int) -> Date {
29+
var dayComponent = DateComponents()
30+
dayComponent.day = days // For removing one day (yesterday): -1
31+
let theCalendar = Calendar.current
32+
guard let nextDate = theCalendar.date(byAdding: dayComponent, to: Date()) else { return Date() }
3433

3534
let dateComponents: DateComponents? = theCalendar.dateComponents([.year, .month, .day], from: nextDate)
36-
37-
let date: Date? = theCalendar.date(from: dateComponents!)
38-
39-
return date!;
35+
guard let date = theCalendar.date(from: dateComponents ?? DateComponents()) else { return Date() }
36+
return date;
4037
}
4138

4239
static func gapYears(date: Date) -> Int {
@@ -53,12 +50,9 @@ extension Date {
5350
let calendar = Calendar.current
5451

5552
var dateComponents: DateComponents? = calendar.dateComponents([.year, .month, .day], from: pastDate)
56-
57-
// dateComponents?.day = 17
58-
// dateComponents?.month = 5
5953
dateComponents?.year = Calendar.current.component(.year, from: Date())
60-
let date: Date? = calendar.date(from: dateComponents!)
61-
return date!;
54+
guard let date = calendar.date(from: dateComponents ?? DateComponents()) else { return Date() }
55+
return date;
6256
}
6357

6458
}

Swift/AnniversaryCalculator/AnniversaryCalculatorDemo/ViewController.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ class ViewController: UIViewController {
1414
super.viewDidLoad()
1515
// Do any additional setup after loading the view.
1616

17-
for couple in self.viewModel.couples {
17+
for couple in viewModel.couples {
1818
if couple.shouldAnniversaryToRemind() {
19-
self.viewModel.couplesToRemind.append(couple)
19+
viewModel.couplesToRemind.append(couple)
2020
}
2121
}
22-
print("shouldAnniversaryToRemind: " , self.viewModel.couplesToRemind)
22+
print(viewModel.couplesToRemind)
2323
}
2424

2525

Swift/AnniversaryCalculator/AnniversaryCalculatorDemo/ViewModel.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
import Foundation
99

1010
class ViewModel {
11-
12-
var couples : Array = Array<Couple>();
13-
var couplesToRemind : Array = Array<Couple>();
11+
var couples: [Couple] = []
12+
var couplesToRemind: [Couple] = [];
1413

1514
init() {
1615
let Couple_1 = Couple(

Swift/AnniversaryCalculator/AnniversaryCalculatorDemoTests/AnniversaryCalculatorDemoTests.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,36 +11,36 @@ import XCTest
1111

1212
class TestViewModel {
1313

14-
var couples : Array = Array<Couple>();
15-
var couplesToRemind : Array = Array<Couple>();
14+
var couples: [Couple] = []
15+
var couplesToRemind: [Couple] = [];
1616

1717
init() {
1818
let Couple_1 = Couple(
1919
coupleId: "1",
20-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days: (-365+1)))
20+
anniversary: Date.ISOStringFromDate(date: Date().after(days: (-365+1)))
2121
)
2222
let Couple_2 = Couple(
2323
coupleId: "2",
24-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days: (-365+2)))
24+
anniversary: Date.ISOStringFromDate(date: Date().after(days: (-365+2)))
2525

2626
)
2727
let Couple_3 = Couple(
2828
coupleId: "3",
29-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days: (-365*5-6)))//"2017-8-08T03:07:33.457Z"
29+
anniversary: Date.ISOStringFromDate(date: Date().after(days: (-365*5-6)))//"2017-8-08T03:07:33.457Z"
3030

3131
)
3232
let Couple_4 = Couple(
3333
coupleId: "4",
34-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days: (-365*5-5)))//"2017-8-22T03:07:33.457Z"
34+
anniversary: Date.ISOStringFromDate(date: Date().after(days: (-365*5-5)))//"2017-8-22T03:07:33.457Z"
3535

3636
)
3737
let Couple_5 = Couple(
3838
coupleId: "5",
39-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days:(-365*10-13)))//"2012-8-01T03:07:33.457Z"
39+
anniversary: Date.ISOStringFromDate(date: Date().after(days:(-365*10-13)))//"2012-8-01T03:07:33.457Z"
4040
)
4141
let Couple_6 = Couple(
4242
coupleId: "6",
43-
anniversary: Date.ISOStringFromDate(date: Date().afterDays(days: (-365*10-12)))//"2012-8-15T03:07:33.457Z"
43+
anniversary: Date.ISOStringFromDate(date: Date().after(days: (-365*10-12)))//"2012-8-15T03:07:33.457Z"
4444
)
4545
couples = [
4646
Couple_1,

0 commit comments

Comments
 (0)