Skip to content

Commented out flaky test and ran scalafmt #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lor6 merged 2 commits into from
Oct 10, 2023
Merged

Commented out flaky test and ran scalafmt #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aec13c8
Commented out flaky test and ran scalafmt
yadavan88 Sep 6, 2023
1ded009
commeting flakiness
yadavan88 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ libraryDependencies += "org.scala-js" %% "scalajs-env-jsdom-nodejs" % "1.0.0"

resolvers += Resolver.jcenterRepo

addSbtPlugin("net.aichler" % "sbt-jupiter-interface" % "0.8.3")
addSbtPlugin("net.aichler" % "sbt-jupiter-interface" % "0.8.3")
5 changes: 3 additions & 2 deletions scala-akka/src/test/scala-2/com/baeldung/scala/akka/scheduler/SchedulerUnitTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ class SchedulerUnitTest
}
}

"cancel a running scheduler" in {
// commenting this test due to flakiness
/* "cancel a running scheduler" in {
val greeter =
system.actorOf(
Props(classOf[Greetings]),
Expand All @@ -167,7 +168,7 @@ class SchedulerUnitTest
schedulerInstance.isCancelled shouldBe true
expectNoMessage(1.seconds)

}
}*/

"scheduleAtFixedRate should run the next execution at fixed rate even if the previous task took more time" in {
println(
Expand Down
5 changes: 3 additions & 2 deletions ...src/test/scala-2/com/baeldung/scala/randomfixedsizesample/RandomFixedSizeSampleSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ class RandomFixedSizeSampleSpec extends AnyWordSpec with Matchers {
isSorted(list_1) shouldBe false
isSorted(list_2) shouldBe false
}
"ensure getRandomSampleShuffle is the most performant, then goes getRandomSampleZip and then getRandomSampleRec" in {
// We can't really depend on this test to check performance. So commenting this out
/*"ensure getRandomSampleShuffle is the most performant, then goes getRandomSampleZip and then getRandomSampleRec" in {
val list = List.range(0, 10_000)
val sampleSize = 100

Expand All @@ -49,7 +50,7 @@ class RandomFixedSizeSampleSpec extends AnyWordSpec with Matchers {

duration_0 should be > duration_1
duration_1 should be > duration_2
}
}*/

}

Expand Down
1 change: 1 addition & 0 deletions specialized-benchmark/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@