Implemented R-max learning rule and SRM0 neurons#249
Implemented R-max learning rule and SRM0 neurons#249Hananel-Hazan merged 6 commits intoBindsNET:masterfrom Huizerd:master
Conversation
There was a problem hiding this comment.
Looks good to me!
In literature (e.g. Paredes-Valles et al., 2018, Scholarpedia), and in all eligibility traces implemented in the code, spikes/values are added to the trace instead of the trace being reset to 1. It also seems more natural this way.
I'm not so sure about this. This should be an option; I like resetting to one as a default for simplicity. This also makes certain learning rule updates easier to interpret.
Out of curiosity, do you have an example showing how this rule works?
|
@Huizerd Great Job! |
|
Maybe a single README for the |
|
@djsaunde this is better discussed via email... |
|
Yes, that is useful. |
Bumping this. @Huizerd could you implement this change? Namely, make resetting to |
|
@djsaunde Sure! Seems like a good way to allow both. |
|
@Hananel-Hazan Looks good to me. Good to merge? |
|
I am currently working on a simple simulator in which learning rules like these could be demonstrated/experimented with very easily. However, as it's part of my thesis, I cannot add it just yet. I will certainly do so when it's finished, so any examples that might be lacking now will be made up for later! |
|
Thanks @Huizerd, that is great! We will be glad to see your thesis examples. |
Implemented R-max learning rule and SRM0 neurons

2 additions to BindsNET:
I also added the corresponding tests, and changed something about the way spike traces are kept track of:
https://github.com/Hananel-Hazan/bindsnet/blob/4021360cc0f715947bf6dc3f7effab003141cb4c/bindsnet/network/nodes.py#L69
In literature (e.g. Paredes-Valles et al., 2018, Scholarpedia), and in all eligibility traces implemented in the code, spikes/values are added to the trace instead of the trace being reset to 1. It also seems more natural this way.