Slight improve performance #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I don't think this will result in a performance improvement in most cases, especially with GPU Tensors. Re-allocating memory on the GPU is typically more expensively than modifying existing blocks of memory on the GPU. Either way, this change should be made across all nodes, for all reset state variables, if it is to be made at all. |
Collaborator
Author
|
I think the overhead of the search condition is bigger then allocate memory. Although I dont think they allocated memory of ones, it will be easier and faster to assign one(scalar) to all cell in the matrix in GPUs terms. |
Collaborator
|
I’ll take your word for it. In that case, can you make this change for all Nodes objects, and for all the reset state variables? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.