Skip to content

Shallow-water equations on the cubed-sphere miniapp #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valeriabarra wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Shallow-water equations on the cubed-sphere miniapp #550

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8e2361a
tap.sh: Update after rebasing onto main
valeriabarra Nov 9, 2020
5772553
Initial development of SWE solver
valeriabarra Apr 29, 2020
b3a0691
SWE: support for PETSc-3.14 DMPlexGetClosureIndices and DMPlexRestore…
valeriabarra May 15, 2020
09a517b
Add copyright statement, improve summary print and other small edits
valeriabarra Jun 3, 2020
9bdada1
Update tap.sh after rebasing with master
valeriabarra Jun 30, 2020
1fb5d86
Add FormJacobian function
valeriabarra Jun 30, 2020
05378a0
Put H0 as a global variable and compute hs as part of qdata
valeriabarra Jul 1, 2020
fbd6f73
Add documentation
valeriabarra Jul 2, 2020
48f7571
SWE: Add advection test case and skeleton for geostrophic test
valeriabarra Jul 7, 2020
d909027
Makefile: fix clean target recursive rm
valeriabarra Jul 7, 2020
b9a6181
Debugging after changing ncompq
valeriabarra Jul 8, 2020
89caa26
WIP: Jacobian for advection test case
valeriabarra Jul 14, 2020
b6545df
SWE: Assign DM label 'panel' for different faces of initial cube
valeriabarra Jul 16, 2020
ca8aa06
SWE: Add FindPanelEdgeNodes() function to determine which nodes are o…
valeriabarra Jul 17, 2020
d1c4b45
Update comment in area and bpssphere setups
valeriabarra Jul 17, 2020
d6a97a4
SWE: Define coordinate transformations for points expressed with loca…
valeriabarra Jul 21, 2020
b7ae1a0
Add TESTARGS and update sample runs
valeriabarra Jul 21, 2020
7b8a94a
SWE: Change panel ordering, following papers convention
valeriabarra Jul 28, 2020
e0f578e
SWE: Fix bit manipulation algorithm in parallel
valeriabarra Jul 28, 2020
29de1ea
SWE: Update DMPlexCreateSphereMesh() call after change in PETSc's API…
valeriabarra Aug 4, 2020
f205e85
Bpssphere: improve comment
valeriabarra Aug 14, 2020
578b94b
SWE: WIP Improve comment and change in geom factors QFunction
valeriabarra Aug 14, 2020
5cf62be
SWE: Transform 3D global coords to 2D local panel coords and update Q…
valeriabarra Aug 14, 2020
a7d986f
SWE: WIP geometric factors local to panel coord systems
valeriabarra Aug 17, 2020
9d1d2ea
SWE: Put back geometric factors as they were
valeriabarra Aug 17, 2020
eeb1397
WIP SWE: pass sparse matrix to user context to be used in wrapper fun…
valeriabarra Aug 19, 2020
a249dd2
SWE: Inside Setup QFunction make sure to project coordinate field ont…
valeriabarra Aug 19, 2020
ac2ba95
examples/fluids: fix usage bugs
jedbrown Sep 3, 2020
dbc55b5
SWE: Fix set context bug after change in the interface
valeriabarra Sep 4, 2020
f402779
SWE WIP: Fix a bug in advection QFunction
valeriabarra Sep 8, 2020
ede2296
SWE: Initial implementation of generic restriction matrix
valeriabarra Sep 23, 2020
e1808a2
examples/fluids: Move setup-boundary.h to navier-stokes
laylagi Mar 9, 2021
568e5c5
SWE: fixed the double prototyping
laylagi Mar 9, 2021
af0adaf
SWE: style
laylagi Mar 9, 2021
af734c2
SWE: fix the weak form in the explicit scheme
laylagi Mar 15, 2021
3c01fc9
SWE: more comments and update the docs
laylagi Mar 16, 2021
da12e01
SWE: some comments on the div operations
laylagi Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SWE WIP: Fix a bug in advection QFunction 
Still need some debugging
  • Loading branch information
@valeriabarra @laylagi
valeriabarra authored and laylagi committed Mar 21, 2021
commit f402779c363733ff1aaf1d59536f55f78419b375
2 changes: 1 addition & 1 deletion examples/fluids/shallow-water/qfunctions/advection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ CEED_QFUNCTION(SWImplicit_Advection)(void *ctx, CeedInt Q,
u_dot_grad_h += u[j] * dhdx_j;
}
CeedScalar strongConv = (h + H0) *div_u + u_dot_grad_h;
CeedScalar strongResid = qdot[4][i] + strongConv;
CeedScalar strongResid = qdot[2][i] + strongConv;

v[2][i] = wdetJ * qdot[2][i]; // transient part (ALWAYS)

Expand Down