Use the inlineCompletionsAdditions proposal#35
Closed
AnthonyLenglet wants to merge 1 commit intoCodedotAl:masterfrom
AnthonyLenglet:api-proposal-update
Closed
Use the inlineCompletionsAdditions proposal#35AnthonyLenglet wants to merge 1 commit intoCodedotAl:masterfrom AnthonyLenglet:api-proposal-update
AnthonyLenglet wants to merge 1 commit intoCodedotAl:masterfrom
AnthonyLenglet:api-proposal-update
Conversation
The inlineCompletions API is now in the official release however, this plugin still needs the inlineCompletions api (also worth noting that this only works in vscode insiders)
ncoop57
pushed a commit
that referenced
this pull request
Jul 1, 2023
Collaborator
|
Thank you very much for the PR! As you stated the inline proposal api is no longer a proposal and is now officially supported. We could add the new inline addition one, but I think it makes more sense for everyone to just remove the proposals from the extension and go with the official one. I went ahead and made a commit that does this: #1b1edf6ccbb2568cb1873459f53d63f5b6dbce2e. So, I'm going to go ahead and close this PR. Thank you again for contributed to the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inlineCompletions API is now in the official release; however, this plugin still needs the inlineCompletions api
(also worth noting that this only works in vscode insiders, using vscode and
--enable-proposed-apidoesn't seem to work)Fixes #34, Fixes #14