Changing old name Sherpa Romeo to new name Open Policy Finder

[Andrea-Guevara]

References

• Fixes Sherpa Romeo new name and translations #3680

Description

Changing from the old name “Sherpa Romeo” to the new name “Open Policy Finder” in the translation files.

Instructions for Reviewers

List of changes in this PR:

• In the .json5 translation files where the name “Sherpa Romeo” appeared, it was changed to “Open Policy Finder”.

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[saschaszott]

@Andrea-Guevara , thanks for this PR (I was not aware of this change).

Aside from this change in the naming, the Sherpa Services API (now "legacy API") will be replaced in the near future with a new API platform:

The Open Policy Finder development team is currently working to build a new API platform to support our user's needs.
While we are working on this, we are continuing to support the legacy Sherpa Services API for existing users.

Should we better open an issue in the DSpace backend project as a reminder since DSpace uses the Sherpa Services API (added with this PR DSpace/DSpace#8271)?

[alanorth]

Thanks @Andrea-Guevara. There are a few more, for example in the submission form:

And there are some others if you search for "Sherpa". Some will require code changes, for example:

$ find src -iname "*sherpa*"
src/app/core/submission/models/sherpa-policies-details.model.ts
src/app/core/submission/models/workspaceitem-section-sherpa-policies.model.ts
src/app/shared/mocks/section-sherpa-policies.service.mock.ts
src/app/submission/sections/sherpa-policies
src/app/submission/sections/sherpa-policies/section-sherpa-policies.component.html
src/app/submission/sections/sherpa-policies/section-sherpa-policies.component.scss
src/app/submission/sections/sherpa-policies/section-sherpa-policies.component.spec.ts
src/app/submission/sections/sherpa-policies/section-sherpa-policies.component.ts

Not sure if we want to get sidetracked by this, and just update the user-facing strings first and tackle the other changes later.

[github-actions]

Hi @Andrea-Guevara,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!