Skip to content

Sequences restructuring#331

Closed
Pwhsky wants to merge 8 commits intoDeepTrackAI:developfrom
Pwhsky:sequences-restructuring
Closed

Sequences restructuring#331
Pwhsky wants to merge 8 commits intoDeepTrackAI:developfrom
Pwhsky:sequences-restructuring

Conversation

@Pwhsky
Copy link
Collaborator

@Pwhsky Pwhsky commented May 14, 2025

WIP of restructuring sequences.py and SequentialProperty.

Changes to SequentialProperty:

  • SequentialProperty now has two new methods:

set_sequence_length(), set_sequence_step(), which lets you directly set the Property.sequence_length and Property.sequence_step attributes without having to use SequentialProperty.store().

  • SequentialProperty now has one new optional argument:

current_value, which is assigned to the SequentialProperty.current attribute upon calling __init__().

Changes to Feature:

to_sequential() is a new Feature class method intended to replace the Sequential() method found in sequences.py.

Sequential() is used as:

rotating_ellipse = deeptrack.sequences.Sequential(rotation=get_rotation)
imaged_rotating_ellipse = optics(rotating_ellipse)

The new Feature method to_sequential() is used as:

rotating_ellipse = ellipse.to_sequential(rotation=get_rotation)
imaged_rotating_ellipse = optics(rotating_ellipse)

@Pwhsky Pwhsky marked this pull request as ready for review May 26, 2025 10:42
resolve = __call__

def to_sequential(
feature: Feature,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be self

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected.

@Pwhsky Pwhsky closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants