Skip to content

Conversation

@danthedaniel
Copy link

@danthedaniel danthedaniel commented Sep 9, 2016

What does this PR do?

  1. Fixes incorrect recursive calls to _set_param_recursive()
  2. Removes criterion from ExtraTreesRegressor in the regressor version of SelectFromModel
  3. Replaces all instances of sep parameter in calls to np.recfromcsv() with delimiter

tpot/base.py Outdated
self._set_param_recursive(obj.steps, parameter, value)
elif hasattr(obj, 'transformer_list'):
self._set_param_recursive(obj.transformer_list)
self._set_param_recursive(obj.transformer_list, parameter, value)
Copy link
Author

@danthedaniel danthedaniel Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting the first bugfix

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 88.011% when pulling 5b69414 on teaearlgraycold:bugfixes into 233e7cf on rhiever:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.178% when pulling 1d982b5 on teaearlgraycold:bugfixes into 233e7cf on rhiever:master.

@rhiever rhiever added the bug label Sep 12, 2016
@rhiever rhiever merged commit 959cd23 into EpistasisLab:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants