Skip to content

Conversation

@weixuanfu
Copy link

@weixuanfu weixuanfu commented Jun 16, 2017

  1. Fix a bug that "DEFAULT" in the parameter(s) of nested estimator causes KeyError when exporting pipeline, which is related to the issue fit() doesn't end properly (no best pipeline) #499

  2. Add a unit test for this issue

The 2 lines in operator_utils.py cause the bug in the issue #499. It works all right with operators without nested/stacked estimator as parameter(s) but it will cause KeyError once dep_op_arguments do not have nested/stacked estimator's name as key of the dictionary. It means that if any parameter is DEFAULT in the nested/stacked estimator would cause the whole pipeline cannot exported as valid scikit-learn Pipeline object.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 91.797% when pulling 3537317 on weixuanfu2016:issue499 into c427093 on rhiever:development.

@weixuanfu weixuanfu changed the title A patch for "DEFAULT" in the parameter(s) of nested estimators A patch for "DEFAULT" values in the parameter(s) of nested estimators Jun 16, 2017
@weixuanfu weixuanfu changed the title A patch for "DEFAULT" values in the parameter(s) of nested estimators A patch for "DEFAULT" value in the parameter(s) of nested estimators Jun 16, 2017
@weixuanfu
Copy link
Author

Update: after discussions with @rhiever, we decide to remove DEFAULT value in terminal since it is confusing as default in TPOT. And user can easily use config_dict parameter to add default value back based on scikit-learn online documentation.

@weixuanfu weixuanfu changed the title A patch for "DEFAULT" value in the parameter(s) of nested estimators Removing DEFAULT value in terminals Jun 16, 2017
@weixuanfu weixuanfu changed the title Removing DEFAULT value in terminals Removing "DEFAULT" value in terminals Jun 16, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.288% when pulling 7c44a67 on weixuanfu2016:issue499 into c427093 on rhiever:development.

@rhiever rhiever self-requested a review June 16, 2017 16:23
@rhiever rhiever merged commit 2b0c29c into EpistasisLab:development Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants