Skip to content

Conversation

@tonyinme
Copy link
Contributor

@tonyinme tonyinme commented Apr 9, 2021

Hey @jrood-nrel and @sayerhs, I am adding this pull request to start the process on getting an example that uses openfast within the repository. @sayerhs mentioned we might not be ready for this yet, but I'd like to have this here so we don't forget. Let me know what else I should do.

Thanks!
Tony

@sayerhs sayerhs marked this pull request as draft April 11, 2021 16:56
@tonyinme tonyinme marked this pull request as ready for review January 21, 2022 19:39
Copy link
Contributor

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked a few of them, but there are multiple hard absolute coded paths in here that are not suitable for merging. There are also some binary, and cmake generated files that should be removed. I think what we need to do here is create a new repository specifically for managing this test that will compile the servo library and make that a submodule to amr-wind and nalu-wind

@tonyinme
Copy link
Contributor Author

Thanks @psakievich , I deleted the extra files.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants