Open
Conversation
Easy/Pascal_Triangle.java
Outdated
| @@ -0,0 +1,57 @@ | |||
| /* | |||
Owner
There was a problem hiding this comment.
This is not JavaDoc comment. Like I mentioned in the last PR, it starts with /** and ends with */, each row should have a * at it's beginning. It should be placed right above the class name. Please refer to my previous code here.
Owner
|
Great to see that you actually use recursion to solve the problem. It's very good practice. But the code looks a bit messy. It would be much cleaner if you use loop instead. |
Collaborator
Author
|
I programed in the leetcode first and copy to eclipse. The JavaDoc comment is from eclipse and the tab width is 4 in leetcode... |
Owner
|
@JoannaCode Then you probably need to format it using IDE before commit. |
Collaborator
Author
|
OK. Let me try. I use JS instead of Java in work. So I am not familiar with Java format ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@FreeTymeKiyan