Chrome app fixes #15
Closed
Chrome app fixes #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late to hopefully enable the chrome management settings to be passed correctly into the webview
…rome management area
…tead of FileError
…tps://client.imaginelearning.com/player it should open the chome app.
IL-15906: Proper passing of parameters to packaged app
add query param for environment
…e` to store settings with Chrome storage. Also added handler for opening external links in new browser tab. (#4)
In Meriden they never got to our browser incompatible error because Chrome wouldn't let us load based on the minimum version set in this manifest file.
We used this method in the old client, it allows us to auto launch the app if installed when using a Clever SSO link. Documentation: https://developer.chrome.com/apps/manifest/url_handlers
Not valid JSON... fixing the problem
* Only allow 1 app instance open * Singleton was deprecated. Setting an app ID
We need to have a better way to handle SSO, I'll comment this out until we have that change in place.
Removing App ID until we can handle SSO
…sion Add videoCapture Permissions
This removes TEST and RC since we can't have more than 1 domain verified.
…to other environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling a crash when redirecting early in the startup cycle, adding query parameter for tracking.