Skip to content

Chrome app fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Chrome app fixes #16

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b889383
Making changes to not crash on a redirect and to capture all traffic …
dseabolt Sep 10, 2019
eb34561
Removing multi-domain support
dseabolt Sep 14, 2019
7886b5b
Renaming the query parameter, and not applying it only when server se…
dseabolt Sep 16, 2019
64dff26
Removing the auto included env query parameter since the login page w…
dseabolt Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ function handleLoadRedirect(event) {
return;
}

document.querySelector('#location').value = event.newUrl;
var location = document.querySelector('#location');
if(location !== null){
location.value = event.newUrl;
}
}

function handleNewWindow(event) {
Expand Down
3 changes: 2 additions & 1 deletion parseSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ function convertServerSettingsToUrl(serverSettings, launchUrl) {
if (serverSettings.env) {
queryString.push('env=' + serverSettings.env);
}

queryString.push('chromeApp');
}

//if no environment set then default to production
Expand All @@ -38,6 +40,5 @@ function convertServerSettingsToUrl(serverSettings, launchUrl) {
}

url += (url.indexOf('?') < 0 ? '?' : '&') + queryString.join('&');

return url;
}