Commit for v700 #10
Merged
Commit for v700 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-prabhudesai
suggested changes
Sep 19, 2017
Contributor
amit-prabhudesai
left a comment
amit-prabhudesai
left a comment
There was a problem hiding this comment.
Please check the notes. Also, I suppose the recommended Google Play Services version should still be 8.4.0? This was changed in the 6.2.4 update, but should be set to the version that QA has certified with.
README.md
Outdated
|
|
||
| ## New in this version | ||
| InMobi SDK v6.2.4 for Android introduces the ability to monetize the lock screen. | ||
| InMobi SDK v7.0.0 for Android introduces the ability to monetize the lock screen. |
Contributor
There was a problem hiding this comment.
The description here needs update.
samples/nativeSample/build.gradle
Outdated
| compile 'com.facebook.fresco:fresco:0.5.0' | ||
| compile 'com.squareup.picasso:picasso:2.5.2' | ||
| compile 'com.android.support:multidex:1.0.1' | ||
| compile 'com.android.support.constraint:constraint-layout:1.0.2' |
Contributor
There was a problem hiding this comment.
Are we actually using ConstraintLayouts?
| */ | ||
| public interface PlacementId { | ||
| long YOUR_PLACEMENT_ID_HERE = 1492763427180L; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Nit: No newline at end-of-file.
| * <p/> | ||
| * Note: Swipe to refresh ads. | ||
| */ | ||
| public class SingleStrandFragment extends Fragment |
Contributor
There was a problem hiding this comment.
We no longer have "strands", so the class name and the class-level Javadoc needs to change.
Contributor
Author
|
@amit-prabhudesai Added changes as per review comments. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit for v700