Conversation
| super.onAdLoadSucceeded(inMobiBanner); | ||
| Log.d(TAG, "onAdLoadSucceeded"); | ||
| } | ||
| try { |
There was a problem hiding this comment.
try/catch block is not necessary for SdkNotInitializedException as the intention is to throw exception only for wrong integration. Publishers following the guidelines need not even handle this exception as it will never occur.
| break; | ||
| case InitializationStatus.INVALID_ACCOUNT_ID: | ||
| case InitializationStatus.UNKNOWN_ERROR: | ||
| Log.d(TAG, "InMobi SDK Initialization Failed. Check logs for more information"); |
There was a problem hiding this comment.
I think we should use Log.e(...);
| break; | ||
| case InitializationStatus.INVALID_ACCOUNT_ID: | ||
| case InitializationStatus.UNKNOWN_ERROR: | ||
| Log.d(TAG, "InMobi SDK Initialization Failed. Check logs for more information"); |
There was a problem hiding this comment.
I think we should use Log.e(...);
| if (inMobiInterstitial.isReady()) { | ||
| if (mShowAdButton != null) { | ||
| mShowAdButton.setVisibility(View.VISIBLE); | ||
| try { |
There was a problem hiding this comment.
try/catch block is not necessary for SdkNotInitializedException as the intention is to throw exception only for wrong integration. Publishers following the guidelines need not even handle this exception as it will never occur.
|
|
||
| mStrands.add(nativeStrand); | ||
| mStrands.add(nativeStrand); | ||
| } catch (SdkNotInitializedException e) { |
There was a problem hiding this comment.
try/catch block is not necessary for SdkNotInitializedException as the intention is to throw exception only for wrong integration. Publishers following the guidelines need not even handle this exception as it will never occur.
| final InMobiNative nativeStrand = new InMobiNative(getActivity(), | ||
| PlacementId.YOUR_PLACEMENT_ID_HERE, new StrandAdListener(position)); | ||
| mStrands.add(nativeStrand); | ||
| } catch (SdkNotInitializedException e) { |
There was a problem hiding this comment.
try/catch block is not necessary for SdkNotInitializedException as the intention is to throw exception only for wrong integration. Publishers following the guidelines need not even handle this exception as it will never occur.
| Log.d(TAG, "Audio state changed"); | ||
| } | ||
| }); | ||
| } catch (SdkNotInitializedException e) { |
There was a problem hiding this comment.
try/catch block is not necessary for SdkNotInitializedException as the intention is to throw exception only for wrong integration. Publishers following the guidelines need not even handle this exception as it will never occur.
| break; | ||
| case InitializationStatus.INVALID_ACCOUNT_ID: | ||
| case InitializationStatus.UNKNOWN_ERROR: | ||
| Log.d(TAG, "InMobi SDK Initialization Failed. Check logs for more information"); |
There was a problem hiding this comment.
I think we should use Log.e(...);
|
|
||
| import com.inmobi.ads.InMobiAdRequestStatus; | ||
| import com.inmobi.ads.InMobiNative; | ||
| import com.inmobi.ads.exceptions.SdkNotInitializedException; |
There was a problem hiding this comment.
Remove unused imports
|
|
||
| import com.inmobi.ads.InMobiAdRequestStatus; | ||
| import com.inmobi.ads.InMobiNative; | ||
| import com.inmobi.ads.exceptions.SdkNotInitializedException; |
There was a problem hiding this comment.
Remove unused imports
|
|
||
| import com.inmobi.ads.InMobiAdRequestStatus; | ||
| import com.inmobi.ads.InMobiInterstitial; | ||
| import com.inmobi.ads.exceptions.SdkNotInitializedException; |
There was a problem hiding this comment.
Remove unused imports
2 participants
No description provided.