release-9.0.4 changes (Init API update, changelog and lib) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwagatoMondal
suggested changes
Mar 6, 2020
Comment on lines
44
to
45
| setContentView(R.layout.banner_base); | ||
| Button xmlIntegration = (Button) findViewById(R.id.xmlSample); |
Contributor
There was a problem hiding this comment.
Please refactor all the code to be executed only post init completion.
Comment on lines
53
to
54
| setContentView(R.layout.activity_interstitial_ads); | ||
|
|
Contributor
There was a problem hiding this comment.
Please refactor all the code to be executed only post init completion.
Comment on lines
48
to
49
| setContentView(R.layout.activity_native_ads); | ||
| Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar); |
Contributor
There was a problem hiding this comment.
Please refactor all the code to be executed only post init completion.
SwagatoMondal
approved these changes
Mar 6, 2020
Contributor
SwagatoMondal
left a comment
SwagatoMondal
left a comment
There was a problem hiding this comment.
Please update README as well
SwagatoMondal
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.