Upgrade Node to v24 #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger-marley-lrn
requested review from
georgios-kanellopoulos-lrn and
michael-linnane-lrn
as code owners
roger-marley-lrn
force-pushed
the
LRN-49243/vendor/node-js-upgrade-to-v24
branch
from
f3aa785 to
ae27a6f
Compare
Contributor
michael-linnane-lrn
left a comment
michael-linnane-lrn
left a comment
There was a problem hiding this comment.
More just questions than changes
I also ran Travis on this branch and it works fine for v24 https://app.travis-ci.com/github/Learnosity/learnosity-sdk-nodejs/builds/276973029?serverType=git
Contributor
georgios-kanellopoulos-lrn
left a comment
georgios-kanellopoulos-lrn
left a comment
There was a problem hiding this comment.
I have no further comments. Happy to approve once Michael's comments are resolved
michael-linnane-lrn
approved these changes
Dec 4, 2025
georgios-kanellopoulos-lrn
approved these changes
Dec 4, 2025
Author
|
Leaving this to @danny-beton-lrn to merge when ready, as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.