[FEATURE] Add better context to DataApiExceptionss#16
Merged
Conversation
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
shtrom
force-pushed
the
fix/dataapiexception-better-context
branch
from
ccba066 to
17f62b2
Compare
shtrom
changed the title
DataApiExceptionss
Contributor
Author
|
@eoghanmcilwaine tit for tat: can you review this one for me? 😁 |
eoghanmcilwaine
approved these changes
May 13, 2019
eoghanmcilwaine
left a comment
eoghanmcilwaine
left a comment
Contributor
There was a problem hiding this comment.
Looks good @shtrom. As a future improvement it might be worth catching potential exceptions from requests to give more specific feedback: https://2.python-requests.org//en/latest/user/quickstart/#errors-and-exceptions
Contributor
Author
|
Yup, it would be nice to expose the underlying Exception. |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Mehani olivier.mehani@learnosity.com
Checklist
Feature
Bug
Security
Documentation
ChangeLog.md updated
Tests added
All testsuites passed
make distcompleted successfully