[BUG] Fix results_iter when API returns an object CAT-213 #35
+95
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannon-eldridge-lrn
changed the title
flakeparadigm
suggested changes
Aug 2, 2019
rhiannon-eldridge-lrn
changed the title
rhiannon-eldridge-lrn
changed the title
rhiannon-eldridge-lrn
changed the title
flakeparadigm
changed the title
…ns an object CAT-213
|
|
||
| def _build_base_url(self): | ||
| @staticmethod | ||
| def __build_base_url(): |
Contributor
Author
There was a problem hiding this comment.
I changed this to a static method as it's only used internally by the integration tests and does not access any class variables.
…I returns an object CAT-213
flakeparadigm
approved these changes
Aug 5, 2019
Contributor
There was a problem hiding this comment.
👍 We'll continue without the CI approvals because it's a config issue in Travis. #36 should cleanup this error, but fine for now.
shtrom
reviewed
Aug 5, 2019
shtrom
reviewed
Aug 5, 2019
learnosity_sdk/request/dataapi.py
Outdated
| for result in response['data']: | ||
| yield result | ||
| if isinstance(response['data'], dict): | ||
| for key, value in Future.iteritems(response['data']): |
Contributor
There was a problem hiding this comment.
No need for Future:
Suggested change
| for key, value in Future.iteritems(response['data']): | |
| for key in response['data']: | |
| yield {key: response['data'][key]} |
shtrom
previously requested changes
Aug 5, 2019
Contributor
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
I don't think we need to add this Future helper.
…when API returns an object CAT-213
Co-Authored-By: Olivier Mehani <[email protected]>
shtrom
reviewed
Aug 6, 2019
Contributor
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
Looks good. Haven't funced.
Contributor
|
We'll have to remember to remove the |
rhiannon-eldridge-lrn
deleted the
CAT-213/bug/fix-results-iter-for-object-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Checklist
Feature
Bug
Security
Documentation
ChangeLog.md updated
Tests added
All testsuites passed
make distcompleted successfully