Skip to content

Conversation

@david-scarratt-lrn
Copy link
Contributor

@david-scarratt-lrn david-scarratt-lrn commented Nov 5, 2021

Summary

Add the ability to build and test in a container. The container command is in an external makefile, requiring selection using -f docker.mk.

Pros

  • Doesn't change the existing Makefile, which is exactly the same whether running locally or in a container
  • Added file is also very simple
  • Doesn't require extra control variables (LRN_SDK_NO_DOCKER)
  • Allows making targets that don't require Python (notably clean) without a container
  • Safe with Docker in Docker

Cons

  • Easy to forget to add -f docker.mk—the choice has to be expressed every time make is invoked
  • Opt-in rather than opt-out
  • Extra file

Checklist

  • Feature

  • Bug

  • Security

  • Documentation

  • ChangeLog.md updated

  • Tests added

  • All testsuites passed

  • make dist completed successfully

Copy link
Contributor

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is for Option 1 in #57. The changes are essentially similar, so I'll put my comments there.

@david-scarratt-lrn
Copy link
Contributor Author

After discussion, the preference overall is for the other option, so closing this.

@david-scarratt-lrn david-scarratt-lrn deleted the LRN-34037/feature/containerise-makefile-external branch November 17, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants