Skip to content

Conversation

@walsh-conor
Copy link
Contributor

@walsh-conor walsh-conor commented Aug 7, 2024

Checklist

  • Feature

  • Bug

  • Security

  • Documentation

  • ChangeLog.md updated

  • Tests added

  • All testsuites passed

  • make dist completed successfully

@walsh-conor walsh-conor force-pushed the LRN-43927/feature/add-workflow-to-release-to-pypi branch from a14e7e6 to 08e2613 Compare August 13, 2024 08:56
Copy link
Contributor

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shtrom
Copy link
Contributor

shtrom commented Aug 13, 2024

I'd suggest to retag the commit as something like [BUILD]

@walsh-conor walsh-conor force-pushed the LRN-43927/feature/add-workflow-to-release-to-pypi branch from 08e2613 to 1bf441e Compare August 14, 2024 08:36
@walsh-conor walsh-conor changed the title [WIP] Add workflow to release to PyPi - LRN-43927 [BUILD] Add workflow to release to PyPi - LRN-43927 Aug 14, 2024
@walsh-conor walsh-conor merged commit 1559cd5 into master Aug 14, 2024
@walsh-conor walsh-conor deleted the LRN-43927/feature/add-workflow-to-release-to-pypi branch August 14, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants